New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AWS attach/detach operations faster #56974

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
6 participants
@gnufied
Member

gnufied commented Dec 8, 2017

Most attach/detach operations on AWS finish within 1-4seconds.
By using a shorter time interval and higher exponetial
factor we can shorten time taken for attach and detach to complete.

After this change retry interval looks like:

[1, 1.8, 3.24, 5.832000000000001, 10.4976]

Before it was:

[10, 12.0, 14.399999999999999, 17.279999999999998]

/sig aws

AWS: Make attach/detach operations faster. from 10-12s to 2-6s
Make AWS attach/detach operations faster
Most attach/detach operations on AWS finish within 1-4seconds.
By using a shorter time interval and higher exponetial
factor  we can shorten time taken for attach and detach to complete.
@gnufied

This comment has been minimized.

Member

gnufied commented Dec 8, 2017

/sig storage

@jsafrane

This comment has been minimized.

Member

jsafrane commented Dec 13, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Dec 13, 2017

@gnufied

This comment has been minimized.

Member

gnufied commented Dec 14, 2017

/test pull-kubernetes-unit
/test pull-kubernetes-e2e-gce

@gnufied

This comment has been minimized.

Member

gnufied commented Dec 15, 2017

@justinsb can you have a look at this PR? it kinda helps in low latency situations. I measured metrics before and after this PR and now I can see most attach operations completing with 5s.

@justinsb

This comment has been minimized.

Member

justinsb commented Dec 18, 2017

/lgtm

@jsafrane

This comment has been minimized.

Member

jsafrane commented Jan 30, 2018

Umm, what's the status of this PR? It misses /approve no-issue.

/retest

@justinsb

This comment has been minimized.

Member

justinsb commented Feb 9, 2018

/approve no-issue

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jsafrane, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

fejta-bot commented Feb 9, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 9, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 9, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 30f54b4 into kubernetes:master Feb 9, 2018

14 of 15 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation gnufied authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-gke-gci Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce-canary Skipped
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment