Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add phase command for dynamic kubelet configuration in kubeadm. #57224
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
First round of comments inline
More general consideration:
enable-dynamic-config implements a step of the
kubeadm join sequence, which is not fully covered by
If we want to preserve this, we should consider if/how make clear to the users which phase to run on the master node and which phase to run on workers
@kad in the current 1.10 cycle, the minimum version of kubelet which kubeadm supports is 1.9.0, and dynamic kubelet config feature is supported in 1.9.0, so I don't think we need to check the kubelet version. WDYT?
@kad I check the feature gate in the phase command and by doing so, I think we don't need to check kubelet version (supposing it's the right version if the feature gate is enabled). WDYT?
referenced this pull request
Feb 26, 2018
[MILESTONENOTIFIER] Milestone Removed From Pull Request
Important: This pull request was missing labels required for the v1.11 milestone for more than 3 days:
kind: Must specify exactly one of
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
The full list of commands accepted by this bot can be found here.
The pull request process is described here