New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard version to v1.8.3 #57326

Merged
merged 1 commit into from Feb 26, 2018

Conversation

Projects
None yet
8 participants
@floreks
Member

floreks commented Dec 18, 2017

What this PR does / why we need it: Updates dashboard addon to the latest version. Changelog can be found here.

Release note:

Update dashboard version to v1.8.3
@floreks

This comment has been minimized.

Member

floreks commented Dec 19, 2017

/assign @jbeda

@floreks floreks changed the title from Update dashboard version to v1.8.1 to Update dashboard version to v1.8.2 Jan 25, 2018

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Jan 26, 2018

@floreks

This comment has been minimized.

Member

floreks commented Jan 28, 2018

Is there a way to check logs of a container that is failing? Without that it is hard to debug.

@liggitt

@joelsmith

This comment has been minimized.

Contributor

joelsmith commented Feb 5, 2018

@floreks Would it be possible to update this PR to go straight to a 1.8.3 as per kubernetes/dashboard#2813 ?
Also, I have opened up a related issue, #59354 and I think that your PR here is probably the better place to fix it instead of my PR #59355 updating to 1.8.3.

@floreks floreks changed the title from Update dashboard version to v1.8.2 to Update dashboard version to v1.8.3 Feb 13, 2018

@@ -7,10 +7,6 @@ metadata:
name: kubernetes-dashboard-minimal
namespace: kube-system
rules:
# Allow Dashboard to create 'kubernetes-dashboard-key-holder' secret.

This comment has been minimized.

@liggitt

liggitt Feb 13, 2018

Member

+1 for this change, probably need to add an empty EnsureExists kubernetes-dashboard-key-holder Secret to the secrets.yaml file

@@ -30,7 +30,7 @@ spec:
priorityClassName: system-cluster-critical
containers:
- name: kubernetes-dashboard
image: k8s.gcr.io/kubernetes-dashboard-amd64:v1.8.0
image: k8s.gcr.io/kubernetes-dashboard-amd64:v1.8.3

This comment has been minimized.

@liggitt

liggitt Feb 13, 2018

Member

can you also change the kubernetes-dashboard-certs volume back to a secret (reverting the dashboard change in
https://github.com/kubernetes/kubernetes/pull/58720/files#diff-7ab88bb7654d97946d6328f11f29d177, now that the dashboard only reads from that mount)

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Feb 14, 2018

@floreks

This comment has been minimized.

Member

floreks commented Feb 14, 2018

@liggitt Done.

@liggitt

This comment has been minimized.

Member

liggitt commented Feb 14, 2018

/lgtm

@floreks

This comment has been minimized.

Member

floreks commented Feb 15, 2018

@liggitt

This comment has been minimized.

Member

liggitt commented Feb 23, 2018

needs squashing
/assign @mikedanese

@mikedanese

This comment has been minimized.

Member

mikedanese commented Feb 23, 2018

/approve
/hold

Please cleanup history.

Sebastian Florek Sebastian Florek
@floreks

This comment has been minimized.

Member

floreks commented Feb 26, 2018

@mikedanese rebased and squashed the commits.

@joelsmith

This comment has been minimized.

Contributor

joelsmith commented Feb 26, 2018

/hold cancel
Removing hold since this PR is squashed now. The failing pull-kubernetes-e2e-gke test is currently not marked required and is failing across the vast majority of PRs. So now this PR just needs a lgtm. Sorry that I don't have enough background in this area to provide a review.

@floreks

This comment has been minimized.

Member

floreks commented Feb 26, 2018

@liggitt could you take a look?

@liggitt

This comment has been minimized.

Member

liggitt commented Feb 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 26, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, liggitt, mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 26, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 26, 2018

@floreks: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gke 85a537c link /test pull-kubernetes-e2e-gke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joelsmith

This comment has been minimized.

Contributor

joelsmith commented Feb 26, 2018

/test pull-kubernetes-unit

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 26, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit c19f8fc into kubernetes:master Feb 26, 2018

11 of 13 checks passed

pull-kubernetes-e2e-gke Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-unit
Details
cla/linuxfoundation floreks authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@floreks floreks deleted the floreks:update-dashboard branch Feb 26, 2018

k8s-merge-robot added a commit that referenced this pull request Mar 1, 2018

Merge pull request #60515 from joelsmith/automated-cherry-pick-of-#58720
-#57326-#60342-upstream-release-1.8

Automatic merge from submit-queue.

[1.8] Automated cherry pick of #58720 #57326 #60342

Cherry pick of #58720 #57326 #60342 on release-1.8.

#58720: Ensure that the runtime mounts RO volumes read-only
#57326: Update Dashboard version to v1.8.3
#60342: Fix nested volume mounts for read-only API data volumes

Note for reviewers:
The Dashboard update is necessary because previous versions of the Dashboard attempted to write to the secret volume on startup, and so the read-only secret volume change prevented the Dashboard from starting. 

```release-note
Update dashboard version to v1.8.3

Containers now mount secret, configMap, downwardAPI and projected volumes read-only. Previously,
container modifications to files in these types of volumes were temporary and reverted by the kubelet
during volume sync. Until version 1.11, setting the feature gate ReadOnlyAPIDataVolumes=false will
preserve the old behavior.
```

k8s-merge-robot added a commit that referenced this pull request Mar 1, 2018

Merge pull request #60258 from joelsmith/automated-cherry-pick-of-#58720
-upstream-release-1.9

Automatic merge from submit-queue.

[1.9] Automated cherry pick of #58720 #57326 #60342

Cherry pick of #58720 #57326 #60342 on release-1.9.

#58720: Ensure that the runtime mounts RO volumes read-only
#57326: Update Dashboard version to v1.8.3
#60342: Fix nested volume mounts for read-only API data volumes

Note for reviewers:
The Dashboard update is necessary because previous versions of the Dashboard attempted to write to the secret volume on startup, and so the read-only secret volume change prevented the Dashboard from starting. 

```release-note
Changes secret, configMap, downwardAPI and projected volumes to mount read-only, instead of allowing applications to write data and then reverting it automatically. Until version 1.11, setting the feature gate ReadOnlyAPIDataVolumes=false will preserve the old behavior. Updates dashboard version to v1.8.3 to avoid writing to read-only locations.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment