Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upadd hostPorts to pod describer #57507
Conversation
k8s-ci-robot
assigned
mengqiy and
shiywang
Dec 21, 2017
k8s-ci-robot
added
release-note-none
size/S
cncf-cla: yes
labels
Dec 21, 2017
| if strings.Contains(hostPortString, ",") { | ||
| w.Write(LEVEL_2, "HostPorts:\t%s\n", hostPortString) | ||
| } else { | ||
| if len(hostPortString) == 1 { |
This comment has been minimized.
This comment has been minimized.
php-coder
Dec 21, 2017
•
Contributor
This condition looks weird. When the length of the string can be equal to 1?
This comment has been minimized.
This comment has been minimized.
| if len(hostPortString) == 0 { | ||
| w.Write(LEVEL_2, "HostPort:\t<none>\n") | ||
| } else { | ||
| w.Write(LEVEL_2, "HostPort:\t%s\n", hostPortString) |
This comment has been minimized.
This comment has been minimized.
php-coder
Dec 22, 2017
Contributor
I think that having more if conditions just for respecting plural form doesn't worth it. This code also could benefit from using stringOrNone():
w.Write(LEVEL_2, "HostPorts:\t%s\n", stringOrNone(hostPortString))
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@kubernetes/sig-cli-pr-reviews PTAL. Thanks. |
k8s-ci-robot
added
the
sig/cli
label
Dec 26, 2017
This comment has been minimized.
This comment has been minimized.
|
/assign juanvallejo |
k8s-ci-robot
assigned
juanvallejo
Jan 2, 2018
| } | ||
| hostPortString := describeContainerHostPorts(container.Ports) | ||
| if strings.Contains(hostPortString, ",") { | ||
| w.Write(LEVEL_2, "HostPorts:\t%s\n", hostPortString) |
This comment has been minimized.
This comment has been minimized.
| if strings.Contains(hostPortString, ",") { | ||
| w.Write(LEVEL_2, "HostPorts:\t%s\n", hostPortString) | ||
| } else { | ||
| w.Write(LEVEL_2, "HostPort:\t%s\n", stringOrNone(hostPortString)) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@dixudx one nit, otherwise lgtm |
This comment has been minimized.
This comment has been minimized.
|
@juanvallejo @php-coder Updated. PTAL. Thanks. |
This comment has been minimized.
This comment has been minimized.
|
/lgtm |
k8s-ci-robot
assigned
php-coder
Jan 12, 2018
k8s-ci-robot
added
the
lgtm
label
Jan 12, 2018
This comment has been minimized.
This comment has been minimized.
|
ping @smarterclayton @kubernetes/sig-cli-maintainers for approval. Thanks. |
This comment has been minimized.
This comment has been minimized.
|
/test all Tests are more than 96 hours old. Re-running tests. |
k8s-ci-robot
assigned
soltysh
Jan 16, 2018
This comment has been minimized.
This comment has been minimized.
|
/test all Tests are more than 96 hours old. Re-running tests. |
This comment has been minimized.
This comment has been minimized.
|
/approve no-issue |
This comment has been minimized.
This comment has been minimized.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, dixudx, php-coder, soltysh Associated issue requirement bypassed by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
label
Jan 16, 2018
This comment has been minimized.
This comment has been minimized.
|
/test all [submit-queue is verifying that this PR is safe to merge] |
This comment has been minimized.
This comment has been minimized.
|
/test all Tests are more than 96 hours old. Re-running tests. |
This comment has been minimized.
This comment has been minimized.
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
dixudx commentedDec 21, 2017
What this PR does / why we need it:
Missing
HostPortswhen describing podsWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/assign @mengqiy @shiywang
Release note: