Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated copyrights for 2018 #57735

Merged

Conversation

@cblecker
Copy link
Member

commented Jan 2, 2018

What this PR does / why we need it:

  • Update boilerplate regex to support 2018
  • Add generated runtime and generated device plugin scripts to hack/update-all.sh target list
  • Run make update to regenerate all generated code

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #57728

Special notes for your reviewer:

Release note:

NONE

cblecker added some commits Jan 2, 2018

@cblecker cblecker force-pushed the cblecker:2018-is-the-year-of-kubernetes branch from 0da1904 to 80e3446 Jan 2, 2018

@cblecker cblecker changed the title [WIP] Update generated copyrights for 2018 Update generated copyrights for 2018 Jan 2, 2018

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2018

/unassign
/assign @ixdy @thockin @smarterclayton

@m1093782566

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

+100 THANKS!

@mkumatag
Copy link
Member

left a comment

/lgtm

@cblecker

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2018

/priority critical-urgent
@wojtek-t I don’t know if you’re online for CET today, but if so, would you mind reviewing?

@dims

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

/approve

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

/approve no-issue

Thanks!

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims, mkumatag, wojtek-t

Associated issue: #57728

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@wojtek-t wojtek-t self-assigned this Jan 2, 2018

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

/retest

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2018

Automatic merge from submit-queue (batch tested with PRs 57735, 57503). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit b098caf into kubernetes:master Jan 2, 2018

13 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke-gci Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@mbohlool

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

cc @jpbetz

@cblecker cblecker deleted the cblecker:2018-is-the-year-of-kubernetes branch Jan 2, 2018

@mbohlool

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

trying to cp this into 1.9 but a test is failing: #57767

Do you guys have any idea why?

mbohlool pushed a commit that referenced this pull request Jan 3, 2018

Mehdy Bohlool
Merge pull request #57767 from mbohlool/automated-cherry-pick-of-#577…
…35-upstream-release-1.9

Automated cherry pick of #57735: Update boilerplate for 2018
@cblecker

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2018

1.9: #57767
1.8: #57771
Will work on the cherry-pick for 1.7 later

@nikhita

This comment has been minimized.

Copy link
Member

commented Jan 3, 2018

This PR has the best branch name ever :)

@m1093782566

This comment has been minimized.

Copy link
Member

commented Jan 3, 2018

👍

@nikhita

This comment has been minimized.

Copy link
Member

commented Jan 3, 2018

For 1.7: #57796 #57804

k8s-github-robot pushed a commit that referenced this pull request Jan 3, 2018

Kubernetes Submit Queue
Merge pull request #57771 from cblecker/automated-cherry-pick-of-#577…
…35-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #57735: Update boilerplate for 2018

Cherry pick of #57735 on release-1.8.

#57735: Update boilerplate for 2018

k8s-github-robot pushed a commit that referenced this pull request Jan 4, 2018

Kubernetes Submit Queue
Merge pull request #57804 from cblecker/nikhita-update-to-2018-releas…
…e-1.7

Automatic merge from submit-queue.

release-1.7: Update boilerplate for 2018

**What this PR does / why we need it**:
This is an attempted carry of @nikhita's PR, #57796.
This is acts a cherry pick of #57735.

**Note**: This is not an automated cherry-pick since lots of things have changed since 1.7 and a cherry-pick leads to lots of conflicts in the generated files.

This also unblocks further client-go 4.0 releases. (see #57245)

**Release note**:
```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.