Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockershim: bump the minimum supported docker version to 1.11 #57845

Merged
merged 1 commit into from Jan 10, 2018

Conversation

@yujuhong
Copy link
Member

@yujuhong yujuhong commented Jan 4, 2018

Drop the 1.10 compatibilty code.

Release note:

NONE
Drop the 1.10 compatibilty code.
@Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Jan 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 9, 2018
@Random-Liu
Copy link
Member

@Random-Liu Random-Liu commented Jan 9, 2018

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jan 9, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, yujuhong

Associated issue requirement bypassed by: Random-Liu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dims
Copy link
Member

@dims dims commented Jan 9, 2018

No release note? :)

@yujuhong
Copy link
Member Author

@yujuhong yujuhong commented Jan 10, 2018

No release note? :)

Docker 1.10 was not mentioned in the 1.9 release note as a compatible version. This is more of a code cleanup.

@dims
Copy link
Member

@dims dims commented Jan 10, 2018

ack thanks!

@yujuhong
Copy link
Member Author

@yujuhong yujuhong commented Jan 10, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jan 10, 2018

@yujuhong: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 059fa35 link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link
Contributor

@k8s-github-robot k8s-github-robot commented Jan 10, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 2e9a277 into kubernetes:master Jan 10, 2018
11 of 13 checks passed
11 of 13 checks passed
pull-kubernetes-e2e-gce-device-plugin-gpu Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-verify
Details
cla/linuxfoundation yujuhong authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gke-gci Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@yujuhong yujuhong deleted the yujuhong:minor-clean-up branch Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants