New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volumemetrics for glusterfs plugin. #57993

Merged
merged 1 commit into from Jan 10, 2018

Conversation

Projects
None yet
7 participants
@humblec
Copy link
Contributor

humblec commented Jan 9, 2018

Signed-off-by: Humble Chirammal hchiramm@redhat.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:


@humblec humblec changed the title [WIP] Add volumemetrics from glusterfs plugin. [WIP] Add volumemetrics for glusterfs plugin. Jan 9, 2018

@humblec

This comment has been minimized.

Copy link
Contributor

humblec commented Jan 9, 2018

/release-note-none

@humblec

This comment has been minimized.

Copy link
Contributor

humblec commented Jan 9, 2018

@wongma7 @gnufied PTAL :)

mounter: mounter,
pod: pod,
plugin: plugin,
MetricsProvider: volume.NewMetricsStatFS(plugin.host.GetPodVolumeDir(pod.UID, glusterfsPluginName, spec.Name())),

This comment has been minimized.

@mlmhl

mlmhl Jan 9, 2018

Contributor

Maybe we need to use strings.EscapeQualifiedNameForDisk(glusterfsPluginName) instead of glusterfsPluginName? Because the pod volume path used the former.

This comment has been minimized.

@rootfs

This comment has been minimized.

@humblec

humblec Jan 9, 2018

Contributor

Yep, addressed the comment. Thanks @mlmhl and @rootfs.

mounter: mounter,
pod: &v1.Pod{ObjectMeta: metav1.ObjectMeta{UID: podUID}},
plugin: plugin,
MetricsProvider: volume.NewMetricsStatFS(plugin.host.GetPodVolumeDir(podUID, glusterfsPluginName, volName)),

This comment has been minimized.

@mlmhl

mlmhl Jan 9, 2018

Contributor

The same as above.

This comment has been minimized.

@humblec

humblec Jan 9, 2018

Contributor

Done.

@rootfs

This comment has been minimized.

Copy link
Member

rootfs commented Jan 9, 2018

is it still WIP @humblec ?

Add volumemetrics for glusterfs plugin.
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>

@humblec humblec force-pushed the humblec:volume-metrics branch from cc0ce17 to dc0b7da Jan 9, 2018

@humblec humblec changed the title [WIP] Add volumemetrics for glusterfs plugin. Add volumemetrics for glusterfs plugin. Jan 9, 2018

@humblec

This comment has been minimized.

Copy link
Contributor

humblec commented Jan 9, 2018

@rootfs removed WIP. :)

@humblec

This comment has been minimized.

Copy link
Contributor

humblec commented Jan 9, 2018

/test pull-kubernetes-verify

@gnufied

This comment has been minimized.

Copy link
Member

gnufied commented Jan 9, 2018

/lgtm

@humblec

This comment has been minimized.

Copy link
Contributor

humblec commented Jan 10, 2018

/approve no-issue

@humblec

This comment has been minimized.

Copy link
Contributor

humblec commented Jan 10, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, humblec

Associated issue requirement bypassed by: humblec

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Copy link
Contributor

k8s-merge-robot commented Jan 10, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 10, 2018

@humblec: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit dc0b7da link /test pull-kubernetes-unit
pull-kubernetes-e2e-gce-device-plugin-gpu dc0b7da link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-merge-robot

This comment has been minimized.

Copy link
Contributor

k8s-merge-robot commented Jan 10, 2018

Automatic merge from submit-queue (batch tested with PRs 57993, 58028). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 33134cb into kubernetes:master Jan 10, 2018

9 of 13 checks passed

pull-kubernetes-e2e-gce-device-plugin-gpu Job failed.
Details
pull-kubernetes-unit Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-unit
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation humblec authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gke-gci Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment