New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubeadm] Bump kube-dns to 1.14.8 #58013

Merged
merged 1 commit into from Jan 20, 2018

Conversation

@MrHohn
Member

MrHohn commented Jan 9, 2018

What this PR does / why we need it:
Bump kube-dns to 1.14.8 for kubeadm. Ref #57918.

cc @rramkumar1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #NONE

Special notes for your reviewer:

Release note:

NONE
@cblecker

This comment has been minimized.

Member

cblecker commented Jan 10, 2018

/lgtm
/test pull-kubernetes-e2e-kubeadm-gce
^^ I'm not sure why this didn't run on change (cc: @luxas @BenTheElder)

/assign @krousey
for approval

@cblecker

This comment has been minimized.

Member

cblecker commented Jan 10, 2018

Oh nvm. I see skip report is on for that test. I'm guessing it was broken at some point? It appears to be passing for this PR though:
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/58013/pull-kubernetes-e2e-kubeadm-gce/9974/
https://k8s-gubernator.appspot.com/pr/58013

@fabriziopandini

/lgtm

@krousey

This comment has been minimized.

Member

krousey commented Jan 11, 2018

I would think 1.9.0 and 1.9.1 clusters would still be at the previous version. This seems to bump all the 1.9.x versions to the newer kubedns version.

@MrHohn

This comment has been minimized.

Member

MrHohn commented Jan 11, 2018

I would think 1.9.0 and 1.9.1 clusters would still be at the previous version. This seems to bump all the 1.9.x versions to the newer kubedns version.

Didn't find a precedent at a quick glance. Though I could make the change if that is the right way to handle this.

@fabriziopandini

This comment has been minimized.

Contributor

fabriziopandini commented Jan 11, 2018

I would think 1.9.0 and 1.9.1 clusters would still be at the previous version. This seems to bump all the 1.9.x versions to the newer kubedns version.

Are there any known issue in running 1.9 cluster with kube-dns 1.14.8?

@MrHohn

This comment has been minimized.

Member

MrHohn commented Jan 11, 2018

Are there any known issue in running 1.9 cluster with kube-dns 1.14.8?

Not that I know of. Most of the changes made in kube-dns 1.14.8 were about Prometheus metrics.

@MrHohn

This comment has been minimized.

Member

MrHohn commented Jan 12, 2018

@krousey @fabriziopandini Any update (should we be handling multiple versions)? We'd like to get this in ASAP so that the cherrypick (#58044) can get into the next 1.9 patch release.

@k8s-merge-robot k8s-merge-robot removed the lgtm label Jan 12, 2018

@MrHohn

This comment has been minimized.

Member

MrHohn commented Jan 12, 2018

I would think 1.9.0 and 1.9.1 clusters would still be at the previous version. This seems to bump all the 1.9.x versions to the newer kubedns version.

Added a second commit for this, @krousey @fabriziopandini PTAL and let me know which one to keep, thanks!

@fabriziopandini

This comment has been minimized.

Contributor

fabriziopandini commented Jan 12, 2018

@MrHohn sorry but I missed at my first pass I missed the fact that your intention is to cherry pick this in 1.9.2.
However, considering the very short timeframe for detecting problems, I would like to involve also @roberthbailey @luxas and @timothysc (or if you prefer we can discuss point this in the next sig cluster lifecycle agenda)

@timothysc

This comment has been minimized.

Member

timothysc commented Jan 18, 2018

We don't typically bump in minor versions... Why would we not wait till 1.10?

@timothysc timothysc self-assigned this Jan 18, 2018

@MrHohn

This comment has been minimized.

Member

MrHohn commented Jan 18, 2018

We don't typically bump in minor versions... Why would we not wait till 1.10?

Actually, that sounds good. Would the slightly diverged kube-dns versions between kubeadm and release-branch be a concern?

@timothysc

This comment has been minimized.

Member

timothysc commented Jan 19, 2018

Would the slightly diverged kube-dns versions between kubeadm and release-branch be a concern?

I don't think so, b/c kubeadm selects it's version it deploys.

@MrHohn

This comment has been minimized.

Member

MrHohn commented Jan 19, 2018

Ack, removed the minor versions logic. This PR is now targeting 1.10.

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 19, 2018

@timothysc

/lgtm
/approve

@timothysc

This comment has been minimized.

Member

timothysc commented Jan 19, 2018

/approve no-issue

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 19, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, fabriziopandini, MrHohn, timothysc

Associated issue requirement bypassed by: timothysc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@MrHohn

This comment has been minimized.

Member

MrHohn commented Jan 19, 2018

/retest

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Jan 20, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@MrHohn

This comment has been minimized.

Member

MrHohn commented Jan 20, 2018

/retest

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Jan 20, 2018

Automatic merge from submit-queue (batch tested with PRs 53895, 58013, 58466, 58531, 58535). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit bd1738a into kubernetes:master Jan 20, 2018

11 of 13 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-kops-aws
Details
pull-kubernetes-e2e-kops-aws Job triggered.
Details
cla/linuxfoundation MrHohn authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke-gci Skipped
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment