New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kubeadm] Bump kube-dns to 1.14.8 #58013
[kubeadm] Bump kube-dns to 1.14.8 #58013
Conversation
/lgtm /assign @krousey |
Oh nvm. I see skip report is on for that test. I'm guessing it was broken at some point? It appears to be passing for this PR though: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I would think 1.9.0 and 1.9.1 clusters would still be at the previous version. This seems to bump all the 1.9.x versions to the newer kubedns version. |
Didn't find a precedent at a quick glance. Though I could make the change if that is the right way to handle this. |
Are there any known issue in running 1.9 cluster with kube-dns 1.14.8? |
Not that I know of. Most of the changes made in kube-dns 1.14.8 were about Prometheus metrics. |
@krousey @fabriziopandini Any update (should we be handling multiple versions)? We'd like to get this in ASAP so that the cherrypick (#58044) can get into the next 1.9 patch release. |
Added a second commit for this, @krousey @fabriziopandini PTAL and let me know which one to keep, thanks! |
bed7d6a
to
e97eb42
Compare
@MrHohn sorry but I missed at my first pass I missed the fact that your intention is to cherry pick this in 1.9.2. |
We don't typically bump in minor versions... Why would we not wait till 1.10? |
Actually, that sounds good. Would the slightly diverged kube-dns versions between kubeadm and release-branch be a concern? |
I don't think so, b/c kubeadm selects it's version it deploys. |
e97eb42
to
623ab15
Compare
Ack, removed the minor versions logic. This PR is now targeting 1.10. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, fabriziopandini, MrHohn, timothysc Associated issue requirement bypassed by: timothysc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/retest |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
Automatic merge from submit-queue (batch tested with PRs 53895, 58013, 58466, 58531, 58535). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Bump kube-dns to 1.14.8 for kubeadm. Ref #57918.
cc @rramkumar1
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #NONE
Special notes for your reviewer:
Release note: