Add support for submitting/receiving CRD objects as yaml #58260
Conversation
k8s-ci-robot
added
release-note
and removed
do-not-merge/release-note-label-needed
labels
liggitt
changed the title
|
Updated with integration test:
|
| // TODO: handle this in negotiation | ||
| contentType := req.Header.Get("Content-Type") | ||
| // Remove "; charset=" if included in header. | ||
| if idx := strings.Index(contentType, ";"); idx > 0 { |
sttts
Jan 16, 2018
Contributor
nit: >= 0
nit: >= 0
liggitt
Jan 16, 2018
Author
Member
Preexisting, and I don't think so… leading ; isn't a valid mime type attribute
Preexisting, and I don't think so… leading ; isn't a valid mime type attribute
| return func(w http.ResponseWriter, req *http.Request) { | ||
| // Do this first, otherwise name extraction can fail for unrecognized content types | ||
| // TODO: handle this in negotiation |
sttts
Jan 16, 2018
Contributor
what's meant with the TODO? (I know it pre-existed)
what's meant with the TODO? (I know it pre-existed)
liggitt
Jan 16, 2018
Author
Member
It means to switch this to follow a similar flow with the negotiating serializer, that's just not built for dealing with patch mime types as-is
It means to switch this to follow a similar flow with the negotiating serializer, that's just not built for dealing with patch mime types as-is
sttts
Jan 16, 2018
Contributor
was reading "in negation". negotiation makes more sense actually.
was reading "in negation". negotiation makes more sense actually.
|
Looks good. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt Associated issue: #37455 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
@liggitt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue (batch tested with PRs 58260, 58326). If you want to cherry-pick this change to another branch, please follow the instructions here. |
k8s-github-robot
merged commit a7c65d2
into
kubernetes:master
Fixes #37455