Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for submitting/receiving CRD objects as yaml #58260
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
size/M
cncf-cla: yes
labels
Jan 14, 2018
k8s-merge-robot
assigned
deads2k and
timothysc
Jan 14, 2018
k8s-ci-robot
added
release-note
and removed
do-not-merge/release-note-label-needed
labels
Jan 14, 2018
This was referenced Jan 15, 2018
liggitt
added some commits
Jan 16, 2018
k8s-ci-robot
added
size/L
and removed
size/M
labels
Jan 16, 2018
liggitt
changed the title from
WIP - Add support for submitting/receiving CRD objects as yaml
to
Add support for submitting/receiving CRD objects as yaml
Jan 16, 2018
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
label
Jan 16, 2018
This comment has been minimized.
This comment has been minimized.
|
Updated with integration test:
|
This comment has been minimized.
This comment has been minimized.
k8s-ci-robot
added
the
sig/api-machinery
label
Jan 16, 2018
liggitt
added
the
area/custom-resources
label
Jan 16, 2018
liggitt
assigned
sttts and
nikhita
Jan 16, 2018
| // TODO: handle this in negotiation | ||
| contentType := req.Header.Get("Content-Type") | ||
| // Remove "; charset=" if included in header. | ||
| if idx := strings.Index(contentType, ";"); idx > 0 { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
liggitt
Jan 16, 2018
Member
Preexisting, and I don't think so… leading ; isn't a valid mime type attribute
| return func(w http.ResponseWriter, req *http.Request) { | ||
| // Do this first, otherwise name extraction can fail for unrecognized content types | ||
| // TODO: handle this in negotiation |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
liggitt
Jan 16, 2018
Member
It means to switch this to follow a similar flow with the negotiating serializer, that's just not built for dealing with patch mime types as-is
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looks good. |
This comment has been minimized.
This comment has been minimized.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
label
Jan 16, 2018
This comment has been minimized.
This comment has been minimized.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt Associated issue: #37455 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
label
Jan 16, 2018
This comment has been minimized.
This comment has been minimized.
|
/test all [submit-queue is verifying that this PR is safe to merge] |
This comment has been minimized.
This comment has been minimized.
|
@liggitt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This comment has been minimized.
This comment has been minimized.
|
Automatic merge from submit-queue (batch tested with PRs 58260, 58326). If you want to cherry-pick this change to another branch, please follow the instructions here. |
k8s-merge-robot
merged commit a7c65d2
into
kubernetes:master
Jan 16, 2018
11 of 13 checks passed
timothysc
removed their assignment
Jan 16, 2018
liggitt
deleted the
liggitt:crd-yaml
branch
Jan 17, 2018
liggitt commentedJan 14, 2018
•
edited
Fixes #37455