/kubernetes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the controller manager create and use a valid cobra command #58398

Merged
merged 1 commit into from Jan 18, 2018

Conversation

Reviewers

@ncdc ncdc

@cheftako cheftako

Assignees

@pmorie pmorie

@sttts sttts

@smarterclayton smarterclayton

@thockin thockin

Labels
Projects
None yet
Milestone
No milestone
9 participants
@deads2k @k8s-ci-robot @smarterclayton @k8s-merge-robot @jennybuckley @ncdc @thockin @pmorie @sttts
@deads2k
Contributor

deads2k commented Jan 17, 2018

The controller manager was returning an invalid cobra command that couldn't be executed and then side-stepped it by adding flags separately. This brings it into line.
@k8s-ci-robot

This comment has been minimized.

Sign in to view
Contributor

k8s-ci-robot commented Jan 17, 2018

@deads2k: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed size/S cncf-cla: yes labels Jan 17, 2018

@k8s-merge-robot k8s-merge-robot assigned thockin and pmorie Jan 17, 2018

@deads2k

This comment has been minimized.

Sign in to view
Contributor

deads2k commented Jan 17, 2018

/assign sttts

@kubernetes/sig-api-machinery-bugs

@k8s-ci-robot k8s-ci-robot assigned sttts Jan 17, 2018

@k8s-ci-robot k8s-ci-robot added sig/api-machinery kind/bug labels Jan 17, 2018

@ncdc ncdc referenced this pull request Jan 17, 2018

Closed

Server component commands and hyperkube should be using cobra #34732

15 of 15 tasks complete
cmd/kube-controller-manager/app/controllermanager.go Outdated
@@ -93,6 +93,7 @@ current state towards the desired state. Examples of controllers that ship with
Kubernetes today are the replication controller, endpoints controller, namespace
controller, and serviceaccounts controller.`,
Run: func(cmd *cobra.Command, args []string) {
Run(s)

This comment has been minimized.

Sign in to view
Copy link
@ncdc

ncdc Jan 17, 2018 •
edited

Member

You need to move verflag.PrintAndExitIfRequested() here as the first line in the func

This comment has been minimized.

Sign in to view
Copy link
@deads2k

deads2k Jan 17, 2018

Contributor

You need to move verflag.PrintAndExitIfRequested() here as the first line in the func

done

@deads2k deads2k added release-note-none and removed do-not-merge/release-note-label-needed labels Jan 17, 2018

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Jan 17, 2018

@deads2k deads2k referenced this pull request Jan 17, 2018

Merged

switch hyperkube to cobra #58408

@smarterclayton

This comment has been minimized.

Sign in to view
Contributor

smarterclayton commented Jan 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot assigned smarterclayton Jan 17, 2018

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 17, 2018

@deads2k

This comment has been minimized.

Sign in to view
Contributor

deads2k commented Jan 17, 2018

/approve no-issue
@k8s-ci-robot

This comment has been minimized.

Sign in to view
Contributor

k8s-ci-robot commented Jan 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, smarterclayton

Associated issue requirement bypassed by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Jan 17, 2018

@k8s-merge-robot k8s-merge-robot added the needs-rebase label Jan 18, 2018

@deads2k deads2k added lgtm and removed lgtm labels Jan 18, 2018

@k8s-merge-robot k8s-merge-robot removed the needs-rebase label Jan 18, 2018

@deads2k

This comment has been minimized.

Sign in to view
Contributor

deads2k commented Jan 18, 2018

/retest
@k8s-merge-robot

This comment has been minimized.

Sign in to view
Contributor

k8s-merge-robot commented Jan 18, 2018

/test all [submit-queue is verifying that this PR is safe to merge]
@k8s-merge-robot

This comment has been minimized.

Sign in to view
Contributor

k8s-merge-robot commented Jan 18, 2018

Automatic merge from submit-queue (batch tested with PRs 56258, 58398). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit abdff8a into kubernetes:master Jan 18, 2018
10 of 13 checks passed

10 of 13 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-bazel-test
Details
pull-kubernetes-bazel-test Job triggered.
Details
pull-kubernetes-e2e-gce Job triggered.
Details
cla/linuxfoundation deads2k authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke-gci Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot

This comment has been minimized.

Sign in to view
Contributor

k8s-ci-robot commented Jan 18, 2018 •
edited

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test d7db324 link /test pull-kubernetes-bazel-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

deads2k added a commit to deads2k/kubernetes that referenced this pull request Jan 18, 2018

@k8s-merge-robot @deads2k
Merge pull request kubernetes#58398 from deads2k/controller-09-validcmd 
Automatic merge from submit-queue (batch tested with PRs 56258, 58398). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

make the controller manager create and use a valid cobra command

The controller manager was returning an invalid cobra command that couldn't be executed and then side-stepped it by adding flags separately.  This brings it into line.
0a6bdbd

@deads2k deads2k referenced this pull request Jan 18, 2018

Closed

Use cobra #58472

@jennybuckley

This comment has been minimized.

Sign in to view
Contributor

jennybuckley commented Jan 18, 2018

/cc @cheftako

@k8s-ci-robot k8s-ci-robot requested a review from cheftako Jan 18, 2018

@deads2k deads2k deleted the deads2k:controller-09-validcmd branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment