make the controller manager create and use a valid cobra command #58398
Conversation
|
@deads2k: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. One of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign sttts |
| @@ -93,6 +93,7 @@ current state towards the desired state. Examples of controllers that ship with | |||
| Kubernetes today are the replication controller, endpoints controller, namespace | |||
| controller, and serviceaccounts controller.`, | |||
| Run: func(cmd *cobra.Command, args []string) { | |||
| Run(s) | |||
ncdc
Jan 17, 2018
•
Member
You need to move verflag.PrintAndExitIfRequested() here as the first line in the func
You need to move verflag.PrintAndExitIfRequested() here as the first line in the func
deads2k
Jan 17, 2018
Author
Contributor
You need to move verflag.PrintAndExitIfRequested() here as the first line in the func
done
You need to move verflag.PrintAndExitIfRequested() here as the first line in the func
done
deads2k
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
/lgtm |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, smarterclayton Associated issue requirement bypassed by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 56258, 58398). If you want to cherry-pick this change to another branch, please follow the instructions here. |
k8s-github-robot
merged commit abdff8a
into
kubernetes:master
|
@deads2k: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue (batch tested with PRs 56258, 58398). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. make the controller manager create and use a valid cobra command The controller manager was returning an invalid cobra command that couldn't be executed and then side-stepped it by adding flags separately. This brings it into line.
|
/cc @cheftako |
The controller manager was returning an invalid cobra command that couldn't be executed and then side-stepped it by adding flags separately. This brings it into line.