Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch hyperkube to cobra #58408

Merged
merged 1 commit into from Jan 26, 2018

Conversation

@deads2k
Copy link
Contributor

deads2k commented Jan 17, 2018

This makes use of cobra to layer the commands with a library that already supports composing commands.

Fixes #34732

NONE
@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Jan 17, 2018

@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Jan 17, 2018

/assign ncdc

@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Jan 17, 2018

/retest

@@ -1,77 +0,0 @@
/*

This comment has been minimized.

@smarterclayton

smarterclayton Jan 17, 2018

Contributor

Very satisfying

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Jan 17, 2018

Looks fine to me, but waiting for the remaining prereq PR to finalize comments

@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Jan 18, 2018

/retest

@deads2k deads2k force-pushed the deads2k:hyperkube-01-fix branch from 0206718 to 6f4ab30 Jan 18, 2018

@deads2k deads2k referenced this pull request Jan 18, 2018

Closed

Use cobra #58472

@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Jan 18, 2018

/retest

1 similar comment
@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Jan 18, 2018

/retest

@@ -539,7 +539,7 @@ function start_apiserver {
fi

APISERVER_LOG=${LOG_DIR}/kube-apiserver.log
${CONTROLPLANE_SUDO} "${GO_OUT}/hyperkube" apiserver ${swagger_arg} ${audit_arg} ${authorizer_arg} ${priv_arg} ${runtime_config} \
${CONTROLPLANE_SUDO} "${GO_OUT}/hyperkube" kube-apiserver ${swagger_arg} ${audit_arg} ${authorizer_arg} ${priv_arg} ${runtime_config} \

This comment has been minimized.

@smarterclayton

smarterclayton Jan 19, 2018

Contributor

? Isn't this a breaking change? Or is the old one deprecated?

This comment has been minimized.

@deads2k

deads2k Jan 19, 2018

Author Contributor

? Isn't this a breaking change? Or is the old one deprecated?

Gotta be a bug from 1.0, right? I can re-alias it if need be.

@deads2k deads2k force-pushed the deads2k:hyperkube-01-fix branch 2 times, most recently from 3d0fac7 to 7a220df Jan 19, 2018

@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Jan 19, 2018

@smarterclayton aliased the commands

@mtaufen

This comment has been minimized.

Copy link
Contributor

mtaufen commented Jan 19, 2018

/retest


// MakeSymlinks will create a symlink for each registered hyperkube server in the local directory.
func (hk *HyperKube) MakeSymlinks(command string) error {
//func Usage() {

This comment has been minimized.

@mtaufen

mtaufen Jan 19, 2018

Contributor

is there a reason to keep the usage template as a comment?

This comment has been minimized.

@deads2k

deads2k Jan 19, 2018

Author Contributor

is there a reason to keep the usage template as a comment?

I'm happy to remove it.

@deads2k deads2k force-pushed the deads2k:hyperkube-01-fix branch 2 times, most recently from 0603fc3 to 9b6eac3 Jan 19, 2018

@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Jan 24, 2018

Now with symlinks and different behavior based on binary name.

@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Jan 24, 2018

/retest

@deads2k deads2k force-pushed the deads2k:hyperkube-01-fix branch from 9b6eac3 to e48847e Jan 24, 2018

@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Jan 26, 2018

@smarterclayton let's tie this off

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Jan 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 26, 2018

@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Jan 26, 2018

/lgtm

You're up early :)

@deads2k

This comment has been minimized.

Copy link
Contributor Author

deads2k commented Jan 26, 2018

/approve

to kick bot

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, smarterclayton

Associated issue: #34732

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jan 26, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jan 26, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 6177b42 into kubernetes:master Jan 26, 2018

12 of 13 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-verify
Details
cla/linuxfoundation deads2k authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke-gci Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@deads2k deads2k deleted the deads2k:hyperkube-01-fix branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.