Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Get windows kernel version directly from registry #58498
What this PR does / why we need it:
#55143 gets windows kernel version by calling windows.GetVersion(), but it doesn't work on windows 10. From https://msdn.microsoft.com/en-us/library/windows/desktop/ms724439(v=vs.85).aspx, GetVersion requires app to be manifested.
Applications not manifested for Windows 8.1 or Windows 10 will return the Windows 8 OS version value (6.2). I tried a toy go program using GetVersion on Windows 10 and it returns 0x23f00206.
Given the limited win32 functions in golang, we should read from registry directly.
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
Should also cherry-pick to v1.9.
@feiskyer: GitHub didn't allow me to request PR reviews from the following users: taylorb-microsoft, JiangtianLi.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
referenced this pull request
Jan 25, 2018
[APPROVALNOTIFIER] This PR is APPROVED
Associated issue: #55143
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing