New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make kube-apiserver admission flag disable other plugins 98eb592 #58517

Merged
merged 4 commits into from Jan 19, 2018

Conversation

Projects
None yet
5 participants
@deads2k
Contributor

deads2k commented Jan 19, 2018

The old kube-apiserver flag for enabling admission plugins implicitly disabled ones that were unmentioned. This restores that behavior.

followup to #58123

@hzxuzhonghu You're pretty deep into this now. ptal

/assign hzxuzhonghu
/assign sttts

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 19, 2018

@deads2k: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k

This comment has been minimized.

Contributor

deads2k commented Jan 19, 2018

/approve no issue

@@ -116,8 +116,13 @@ func (a *AdmissionOptions) ApplyTo(
if a.PluginNames != nil {
// pass PluginNames to generic AdmissionOptions
a.GenericAdmission.EnablePlugins = a.PluginNames
a.GenericAdmission.EnablePlugins, a.GenericAdmission.DisablePlugins = computePluginNames(a.PluginNames, a.GenericAdmission.RecommendedPluginOrder)

This comment has been minimized.

@hzxuzhonghu

hzxuzhonghu Jan 19, 2018

Member

You calculate disabled plugins here.Originally, I do this in generic apiserver. Both works well.

@hzxuzhonghu

This comment has been minimized.

Member

hzxuzhonghu commented Jan 19, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 19, 2018

@deads2k

This comment has been minimized.

Contributor

deads2k commented Jan 19, 2018

/approve no-issue

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 19, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hzxuzhonghu

Associated issue requirement bypassed by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Jan 19, 2018

Automatic merge from submit-queue (batch tested with PRs 58517, 57642). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 71d93ab into kubernetes:master Jan 19, 2018

13 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation deads2k authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke-gci Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@deads2k deads2k deleted the deads2k:admission-20-flags branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment