make kube-apiserver admission flag disable other plugins 98eb592 #58517
Conversation
|
@deads2k: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. One of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/release-note-label-needed
deads2k
added
release-note-none
|
/approve no issue |
| @@ -116,8 +116,13 @@ func (a *AdmissionOptions) ApplyTo( | |||
|
|
|||
| if a.PluginNames != nil { | |||
| // pass PluginNames to generic AdmissionOptions | |||
| a.GenericAdmission.EnablePlugins = a.PluginNames | |||
| a.GenericAdmission.EnablePlugins, a.GenericAdmission.DisablePlugins = computePluginNames(a.PluginNames, a.GenericAdmission.RecommendedPluginOrder) | |||
There was a problem hiding this comment.
You calculate disabled plugins here.Originally, I do this in generic apiserver. Both works well.
|
/lgtm |
|
/approve no-issue |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, hzxuzhonghu Associated issue requirement bypassed by: deads2k The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 58517, 57642). If you want to cherry-pick this change to another branch, please follow the instructions here. |
The old kube-apiserver flag for enabling admission plugins implicitly disabled ones that were unmentioned. This restores that behavior.
followup to #58123
@hzxuzhonghu You're pretty deep into this now. ptal
/assign hzxuzhonghu
/assign sttts