Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upreturn reason for allowed rbac authorizations #58531
Conversation
k8s-merge-robot
assigned
enj and
deads2k
Jan 19, 2018
liggitt
referenced this pull request
Jan 19, 2018
Merged
Add PodSecurityPolicy information to audit logs #58143
k8s-ci-robot
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
Jan 19, 2018
This comment has been minimized.
This comment has been minimized.
/lgtm |
k8s-ci-robot
added
the
lgtm
label
Jan 19, 2018
This comment has been minimized.
This comment has been minimized.
/hold cleaning up the subject printing a little |
k8s-ci-robot
added
the
do-not-merge/hold
label
Jan 19, 2018
liggitt
force-pushed the
liggitt:rbac-reason
branch
from
7b29e08
to
1165dbb
Jan 19, 2018
k8s-merge-robot
removed
the
lgtm
label
Jan 19, 2018
This comment has been minimized.
This comment has been minimized.
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
label
Jan 19, 2018
enj
reviewed
Jan 19, 2018
@@ -258,7 +258,7 @@ func TestAppliesTo(t *testing.T) { | |||
} | |||
|
|||
for _, tc := range tests { | |||
got := appliesTo(tc.user, tc.subjects, tc.namespace) | |||
_, got := appliesTo(tc.user, tc.subjects, tc.namespace) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@liggitt why not use more structured output instead of a giant string? |
liggitt
force-pushed the
liggitt:rbac-reason
branch
from
1165dbb
to
b4fb252
Jan 19, 2018
k8s-ci-robot
added
size/L
and removed
size/M
labels
Jan 19, 2018
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
@liggitt /lgtm |
k8s-ci-robot
added
the
lgtm
label
Jan 19, 2018
This comment has been minimized.
This comment has been minimized.
/retest |
This comment has been minimized.
This comment has been minimized.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, enj, liggitt Associated issue: #56209 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
label
Jan 19, 2018
This comment has been minimized.
This comment has been minimized.
Automatic merge from submit-queue (batch tested with PRs 53895, 58013, 58466, 58531, 58535). If you want to cherry-pick this change to another branch, please follow the instructions here. |
liggitt commentedJan 19, 2018
•
edited
includes the binding, role, and subject that allowed a request so audit can make use of it
xref #56209 #58083
example reasons
perf impact
on master:
with this PR: