dockershim: remove the use of kubelet's internal API #58548
Conversation
@yujuhong: Adding do-not-merge/release-note-label-needed because the release note process has not been followed. One of the following labels is required "release-note", "release-note-action-required", or "release-note-none". Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve no-issue |
/test pull-kubernetes-node-e2e |
4fadb1e
to
adc2e94
We let dockershim implement the kubelet's internal (CRI) API as an intermediary step before transitioning fully to communicate using gRPC. Now that kubelet has been communicating to the runtime over gRPC for multiple releases, we can safely retire the extra interface in dockershim.
I removed |
kuberuntime.LegacyLogProvider | ||
} | ||
|
||
// NewDockerLegacyService created docker legacy service when log driver is not supported. |
Random-Liu
Jan 20, 2018
Member
Remove this comment?
Remove this comment?
yujuhong
Jan 20, 2018
Author
Member
Done.
Done.
LGTM with one nit |
Thanks a lot for the review! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy, yujuhong Associated issue requirement bypassed by: yujuhong The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Applied lgtm based on #58548 (comment) |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
bfac95e
into
kubernetes:master
This comment has been minimized.
This comment has been minimized.
@yujuhong Does this mean k8s is no longer using the CRI for docker? |
This comment has been minimized.
This comment has been minimized.
No. It means the opposite. Kubelet has to go through CRI to talk to docker. |
This comment has been minimized.
This comment has been minimized.
@yujuhong Ah, great! Where is the docker CRI implementation now? |
This comment has been minimized.
This comment has been minimized.
It's still in the same location |
We let dockershim implement the kubelet's internal (CRI) API as an
intermediary step before transitioning fully to communicate using gRPC.
Now that kubelet has been communicating to the runtime over gRPC for
multiple releases, we can safely retire the extra interface in
dockershim.
This PR also moves the legacy functions to a separate file and clean up
the interfaces.