/kubernetes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockershim: remove the use of kubelet's internal API #58548

Merged
merged 4 commits into from Jan 20, 2018

Conversation

Reviewers

@Random-Liu Random-Liu

Assignees

@Random-Liu Random-Liu

@ixdy ixdy

Labels
Projects
None yet
Milestone
No milestone
6 participants
@yujuhong @k8s-ci-robot @Random-Liu @ixdy @k8s-merge-robot @shlevy
@yujuhong
Contributor

yujuhong commented Jan 19, 2018

We let dockershim implement the kubelet's internal (CRI) API as an
intermediary step before transitioning fully to communicate using gRPC.
Now that kubelet has been communicating to the runtime over gRPC for
multiple releases, we can safely retire the extra interface in
dockershim.

This PR also moves the legacy functions to a separate file and clean up
the interfaces.

@yujuhong yujuhong self-assigned this Jan 19, 2018

@k8s-ci-robot

This comment has been minimized.

Sign in to view
Contributor

k8s-ci-robot commented Jan 19, 2018

@yujuhong: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed size/XXL cncf-cla: yes labels Jan 19, 2018

@yujuhong yujuhong changed the title from dockershim: remove the use if kubelet's internal API to dockershim: remove the use of kubelet's internal API Jan 19, 2018

@yujuhong yujuhong added release-note-none kind/cleanup and removed do-not-merge/release-note-label-needed labels Jan 19, 2018

@yujuhong

This comment has been minimized.

Sign in to view
Contributor

yujuhong commented Jan 19, 2018

/approve no-issue

@k8s-ci-robot k8s-ci-robot added the approved label Jan 19, 2018

@yujuhong

This comment has been minimized.

Sign in to view
Contributor

yujuhong commented Jan 19, 2018

/test pull-kubernetes-node-e2e

@k8s-ci-robot k8s-ci-robot removed the approved label Jan 20, 2018

yujuhong added some commits Jan 19, 2018

@yujuhong
dockershim: remove the use of kubelet's internal API 
We let dockershim implement the kubelet's internal (CRI) API as an
intermediary step before transitioning fully to communicate using gRPC.
Now that kubelet has been communicating to the runtime over gRPC for
multiple releases, we can safely retire the extra interface in
dockershim.
e8da890
@yujuhong
Fix all the unit tests and update the bazel files
2091028
@yujuhong
dockershim: call DockerService.Start() during grpc server startup
9728c56

@yujuhong yujuhong assigned Random-Liu and unassigned yujuhong Jan 20, 2018

@yujuhong

This comment has been minimized.

Sign in to view
Contributor

yujuhong commented Jan 20, 2018

I removed dockershim/remote from hack/.golint_failures. As a result of this, I'd need the approval from an owner of the hack package.
/assign @ixdy
help?

@k8s-ci-robot k8s-ci-robot assigned ixdy Jan 20, 2018

pkg/kubelet/dockershim/docker_legacy_service.go Outdated
kuberuntime.LegacyLogProvider
}
// NewDockerLegacyService created docker legacy service when log driver is not supported.

This comment has been minimized.

Sign in to view
Copy link
@Random-Liu

Random-Liu Jan 20, 2018

Member

Remove this comment?

This comment has been minimized.

Sign in to view
Copy link
@yujuhong

yujuhong Jan 20, 2018

Contributor

Done.
@Random-Liu

This comment has been minimized.

Sign in to view
Member

Random-Liu commented Jan 20, 2018

LGTM with one nit
@yujuhong

This comment has been minimized.

Sign in to view
Contributor

yujuhong commented Jan 20, 2018

Thanks a lot for the review!
@ixdy

This comment has been minimized.

Sign in to view
Member

ixdy commented Jan 20, 2018

/approve
@k8s-ci-robot

This comment has been minimized.

Sign in to view
Contributor

k8s-ci-robot commented Jan 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, yujuhong

Associated issue requirement bypassed by: yujuhong

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Jan 20, 2018

@yujuhong yujuhong added the lgtm label Jan 20, 2018

@yujuhong

This comment has been minimized.

Sign in to view
Contributor

yujuhong commented Jan 20, 2018

Applied lgtm based on #58548 (comment)
@k8s-merge-robot

This comment has been minimized.

Sign in to view
Contributor

k8s-merge-robot commented Jan 20, 2018

/test all [submit-queue is verifying that this PR is safe to merge]
@k8s-merge-robot

This comment has been minimized.

Sign in to view
Contributor

k8s-merge-robot commented Jan 20, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit bfac95e into kubernetes:master Jan 20, 2018
12 of 13 checks passed

12 of 13 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation yujuhong authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke-gci Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@yujuhong yujuhong deleted the yujuhong:simplify-ds branch Jan 26, 2018

@shlevy

This comment has been minimized.

Sign in to view
Contributor

shlevy commented on e8da890 Feb 7, 2018

@yujuhong Does this mean k8s is no longer using the CRI for docker?

This comment has been minimized.

Sign in to view
Contributor

yujuhong replied Feb 7, 2018

No. It means the opposite. Kubelet has to go through CRI to talk to docker.

This comment has been minimized.

Sign in to view
Contributor

shlevy replied Feb 7, 2018

@yujuhong Ah, great! Where is the docker CRI implementation now?

This comment has been minimized.

Sign in to view
Contributor

yujuhong replied Feb 7, 2018

It's still in the same location pkg/kubelet/dockershim. This PR removed the backdoor for using dockershim directly (without going through CRI w/ grpc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment