New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer apps/v1 storage for daemonsets, deployments, replicasets, statefulsets #58854

Merged
merged 1 commit into from Feb 9, 2018

Conversation

@liggitt
Member

liggitt commented Jan 26, 2018

The workload API objects went GA in 1.9. This means we can safely begin persisting them in etcd in apps/v1 format in 1.10.

xref #43214

DaemonSet, Deployment, ReplicaSet, and StatefulSet objects are now persisted in etcd in apps/v1 format
@liggitt

This comment has been minimized.

Member

liggitt commented Jan 26, 2018

@liggitt

This comment has been minimized.

Member

liggitt commented Jan 26, 2018

/assign @kow3ns

@liggitt liggitt added this to the v1.10 milestone Jan 26, 2018

@liggitt liggitt changed the title from Prefer apps/v1 storage for daemonsets, deployments, replicasets to Prefer apps/v1 storage for daemonsets, deployments, replicasets, statefulsets Jan 26, 2018

@liggitt

This comment has been minimized.

Member

liggitt commented Jan 27, 2018

/retest

@soltysh

This lgtm, but I'll defer to @kow3ns for final sign-off

@soltysh

This comment has been minimized.

Contributor

soltysh commented Feb 7, 2018

@kow3ns gentle ping for singoff

@kow3ns

This comment has been minimized.

Member

kow3ns commented Feb 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 8, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kow3ns, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 9, 2018

Automatic merge from submit-queue (batch tested with PRs 59580, 58854). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 24f3871 into kubernetes:master Feb 9, 2018

14 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce-canary Skipped
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@liggitt liggitt deleted the liggitt:prefer-v1-storage branch Feb 21, 2018

k8s-merge-robot added a commit that referenced this pull request Jul 31, 2018

Merge pull request #66581 from janetkuo/deploy-progress
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

 Default extensions/v1beta1 Deployment's ProgressDeadlineSeconds to MaxInt32

**What this PR does / why we need it**: Default values should be set in all API versions, because defaulting happens whenever a serialized version is read. When we switched to `apps/v1` as the storage version in `1.10` (#58854), `extensions/v1beta1` `DeploymentSpec.ProgressDeadlineSeconds` gets `apps/v1` default value (`600`) instead of being unset. 

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #66135 

**Special notes for your reviewer**: We need to cherrypick this fix to 1.10 and 1.11. Note that this fix will only help people who haven't upgraded to 1.10 or 1.11 when the storage version is changed. 

@kubernetes/sig-apps-bugs 

**Release note**:

```release-note
NONE
```

@tossmilestone tossmilestone referenced this pull request Aug 18, 2018

Merged

Deploy progress #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment