New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for GPU monitoring. #58890

Merged
merged 1 commit into from Jan 27, 2018

Conversation

@mindprince
Member

mindprince commented Jan 26, 2018

Related to kubernetes/enhancements#369.

This is mostly the same code as the default stackdriver test. This would need to be a separate suite because it needs to run with GPUs etc.

Release note:

NONE

/sig instrumentation
/sig testing
/kind enhancement

/assign @vishh @kawych @piosz @jiayingz

@jiayingz

This comment has been minimized.

Member

jiayingz commented Jan 26, 2018

/lgtm for the gpu e2e test part.

@vishh

vishh approved these changes Jan 27, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 27, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiayingz, mindprince, vishh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mindprince

This comment has been minimized.

Member

mindprince commented Jan 27, 2018

/retest

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Jan 27, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@mindprince

This comment has been minimized.

Member

mindprince commented Jan 27, 2018

/retest

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Jan 27, 2018

Automatic merge from submit-queue (batch tested with PRs 58889, 58890). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit e3d754a into kubernetes:master Jan 27, 2018

13 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation mindprince authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment