New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet: remove the rktshim directory #58902

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
6 participants
@yujuhong
Contributor

yujuhong commented Jan 27, 2018

This package contains only placeholders without actual implementation.
Since it is not currently under active development, remove it to avoid
unnecessary change needed whenever the interface is changed.

kubelet: remove the rktshim directory
This package contains only placeholders without actual implementation.
Since it is not currently under active development, remove it to avoid
unnecessary change needed whenever the interface is changed.
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 27, 2018

@yujuhong: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yujuhong

This comment has been minimized.

Contributor

yujuhong commented Jan 27, 2018

/retest

@dchen1107

This comment has been minimized.

Member

dchen1107 commented Jan 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 29, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, yujuhong

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@dchen1107

This comment has been minimized.

Member

dchen1107 commented Jan 29, 2018

cc/ @euank for heads-up

@euank

This comment has been minimized.

Member

euank commented Jan 29, 2018

Belated /lgtm, thanks for getting this!

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Jan 29, 2018

Automatic merge from submit-queue (batch tested with PRs 56995, 58498, 57426, 58902, 58863). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit a58ca14 into kubernetes:master Jan 29, 2018

13 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation yujuhong authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@yujuhong yujuhong deleted the yujuhong:rm-rktshim branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment