New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --tls-ca-file which had no effect #58968

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
4 participants
@deads2k
Contributor

deads2k commented Jan 29, 2018

The flag has had no effect since we started configuring loopback based on the direct cert. I've marked it deprecated this release so we don't break launch scripts right away, but its coming. I think we should remove it in 1.11.

kube-apiserver flag --tls-ca-file has had no effect for some time.  It is now deprecated and slated for removal in 1.11.  If you are specifying this flag, you must remove it from your launch config before ugprading to 1.11.
@deads2k

This comment has been minimized.

Contributor

deads2k commented Jan 29, 2018

/retest

@dims

This comment has been minimized.

Member

dims commented Jan 29, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dims

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Jan 29, 2018

Automatic merge from submit-queue (batch tested with PRs 58955, 58968, 58971, 58963, 58298). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit d8f32b2 into kubernetes:master Jan 29, 2018

13 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation deads2k authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

githubixx pushed a commit to githubixx/ansible-role-kubernetes-controller that referenced this pull request Jun 3, 2018

BenChapman added a commit to cloudfoundry-incubator/kubo-release that referenced this pull request Jun 11, 2018

Remove deprecated tls-ca-file flag
- kubernetes/kubernetes#58968

[#158183539]

Signed-off-by: Urvashi Reddy <ureddy@pivotal.io>

githubixx added a commit to githubixx/ansible-role-kubernetes-controller that referenced this pull request Jun 13, 2018

upgrade to K8s v1.10.x (#10)
* removed tls-cert-file setting as it is deprecated (see kubernetes/kubernetes#58968)

* remove deprecated kube-apiserver parameter insecure-bind-address / added variable+parameter secure-port for kube-apiserver

* added kube-controller-manager certificate files to k8s_certificates list

* update README

* added kube-scheduler certificate files to k8s_certificates list

* updated README

* added kube-controller-manager-sa certificate files to k8s_certificates list

* removed unneeded files from k8s_certificates list

* change K8s release to v1.10.3

* added kubeconfig for admin user, controller manager, scheduler / introduce k8s_scheduler_conf_dir, k8s_controller_manager_conf_dir / k8s_release to v1.10.3 / update README

* replaced kube-apiserver parameter admission-control with enable-admission-plugins

* new service-account-key-file value for kube-apiserver

* changes in k8s_controller_manager_settings: removed master parameter, added kubeconfig, new value for service-account-private-key-file, new parameter use-service-account-credentials

* update to K8s v1.10.4

* update README

* implemented needed changes for kube-scheduler

* kubectl now uses --kubeconfig

* fix wrong directory destinations

* added k8s-controller-base tag / fixed wrong tags

@deads2k deads2k deleted the deads2k:server-07-deadarg branch Jul 3, 2018

MaximilianMeister added a commit to MaximilianMeister/salt that referenced this pull request Aug 2, 2018

remove deprecated flag
see kubernetes/kubernetes#58968

k8s#1.11

Signed-off-by: Maximilian Meister <mmeister@suse.de>

fjudith added a commit to fjudith/saltstack-kubernetes that referenced this pull request Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment