New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit kube-proxy when configuration file changes #59176

Merged
merged 1 commit into from Feb 2, 2019

Conversation

@dixudx
Copy link
Member

dixudx commented Feb 1, 2018

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #57144

Special notes for your reviewer:
/assign thockin
/cc smarterclayton liggitt

Release note:

exit kube-proxy when configuration file changes

@k8s-ci-robot k8s-ci-robot requested review from liggitt and smarterclayton Feb 1, 2018

@dixudx dixudx force-pushed the dixudx:reload_kubeproxy_config branch 2 times, most recently from f8764f2 to f060fe5 Feb 1, 2018

Show resolved Hide resolved pkg/util/rerun/rerun.go Outdated
Show resolved Hide resolved pkg/util/rerun/rerun.go Outdated
Show resolved Hide resolved pkg/util/rerun/rerun.go Outdated
Show resolved Hide resolved cmd/kube-proxy/app/server.go Outdated
Show resolved Hide resolved cmd/kube-proxy/app/server.go Outdated

@dixudx dixudx force-pushed the dixudx:reload_kubeproxy_config branch from f060fe5 to 1a6e181 Feb 27, 2018

@dixudx dixudx force-pushed the dixudx:reload_kubeproxy_config branch from 1a6e181 to 6445d4c Feb 27, 2018

@dixudx dixudx changed the title reloads kube-proxy config when configuration file changes exit kube-proxy when configuration file changes Feb 27, 2018

@dixudx

This comment has been minimized.

Copy link
Member Author

dixudx commented Mar 23, 2018

@liggitt @thockin Updated. PTAL. Thanks.

Show resolved Hide resolved cmd/kube-proxy/app/server.go Outdated
Show resolved Hide resolved cmd/kube-proxy/app/server.go Outdated

@dixudx dixudx force-pushed the dixudx:reload_kubeproxy_config branch 2 times, most recently from d01c6e4 to c606984 Apr 25, 2018

Show resolved Hide resolved cmd/kube-proxy/app/server.go Outdated
Show resolved Hide resolved cmd/kube-proxy/app/server.go Outdated
@thockin

This comment has been minimized.

Copy link
Member

thockin commented May 14, 2018

This could use some unit test

@dixudx dixudx force-pushed the dixudx:reload_kubeproxy_config branch from c606984 to 49d3a90 May 15, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels May 15, 2018

@dixudx dixudx force-pushed the dixudx:reload_kubeproxy_config branch from 49d3a90 to a35cf8a May 15, 2018

@dixudx

This comment has been minimized.

Copy link
Member Author

dixudx commented Jan 29, 2019

@thockin The tests turn green now. It's ready for review. PTAL. Thanks.

@dixudx

This comment has been minimized.

Copy link
Member Author

dixudx commented Jan 29, 2019

pull-kubernetes-e2e-kops-aws is flaky now. Will retest it when recovered.

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Jan 30, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 30, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 30, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

5 similar comments
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 31, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 31, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 31, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 31, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 31, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@vllry

This comment has been minimized.

Copy link
Contributor

vllry commented Jan 31, 2019

/hold

The kops test environment is still unavailable. Right now that test suite is optional for merges.

@vllry

This comment has been minimized.

Copy link
Contributor

vllry commented Jan 31, 2019

Whoops, I only thought hold would silence the bot :(

/hold cancel

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 31, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

8 similar comments
@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 31, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 1, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 1, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 1, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 1, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 1, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 1, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 1, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 1, 2019

@dixudx: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-kubemark-e2e-gce ac1b58a link /test pull-kubernetes-kubemark-e2e-gce
pull-kubernetes-e2e-kops-aws cc16d64 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims

This comment has been minimized.

Copy link
Member

dims commented Feb 2, 2019

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 73ccf56 into kubernetes:master Feb 2, 2019

18 checks passed

cla/linuxfoundation dixudx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Context retired without replacement.
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
// error out when ConfigFile is updated
o.errCh <- fmt.Errorf("content of the proxy server's configuration file was updated")
}
o.errCh <- nil

This comment has been minimized.

@tedyu

tedyu Feb 2, 2019

Contributor

If line 262 is executed, is this still needed ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment