New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI 0.2.0 breaking changes #59209

Merged
merged 2 commits into from Feb 17, 2018

Conversation

@sbezverk
Contributor

sbezverk commented Feb 1, 2018

Refactor kubernetes CSI bits to support CSI version 0.2.0

Addressing breaking changes introduced by new 0.2.0 release of CSI spec
@sbezverk

This comment has been minimized.

Contributor

sbezverk commented Feb 1, 2018

/sig storage
/kind bug
/assign @saad-ali @vladimirvivien

@sbezverk sbezverk changed the title from Csi 0.2.0 breaking changes to CSI 0.2.0 breaking changes Feb 1, 2018

@k8s-ci-robot k8s-ci-robot added size/S size/M and removed size/XS size/S labels Feb 1, 2018

@sbezverk

This comment has been minimized.

Contributor

sbezverk commented Feb 15, 2018

@saad-ali @vladimirvivien @lpabon I have tested successfully this k8s csi core change with all external components:
external-provisioner, external-attacher, driver-registrar and rbdplugin all on v0.2.0 spec.
I think it is ready, appreciate your input.

@saad-ali

This comment has been minimized.

Member

saad-ali commented Feb 16, 2018

We can pick up the official 0.2 once that is cut (hoping that will happen EOW next week).

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 16, 2018

@saad-ali

This comment has been minimized.

Member

saad-ali commented Feb 16, 2018

For vendor dir approval

/assign @brendanburns

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 16, 2018

@saad-ali: GitHub didn't allow me to assign the following users: brendanburns.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

For vendor dir approval

/assign @brendanburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbezverk

This comment has been minimized.

Contributor

sbezverk commented Feb 16, 2018

/assign @brendandburns

@brendandburns

This comment has been minimized.

Contributor

brendandburns commented Feb 16, 2018

We generally split the vendor updates out as a separate commit.

@k8s-ci-robot k8s-ci-robot removed the size/XL label Feb 16, 2018

@k8s-ci-robot k8s-ci-robot added the size/S label Feb 16, 2018

@k8s-merge-robot k8s-merge-robot removed the lgtm label Feb 16, 2018

@sbezverk

This comment has been minimized.

Contributor

sbezverk commented Feb 16, 2018

@saad-ali

This comment has been minimized.

Member

saad-ali commented Feb 17, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 17, 2018

@sbezverk

This comment has been minimized.

Contributor

sbezverk commented Feb 17, 2018

/assign @brendandburns

@brendandburns

This comment has been minimized.

Contributor

brendandburns commented Feb 17, 2018

/approve no-issue

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, saad-ali, sbezverk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 17, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 17, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 220bdf2 into kubernetes:master Feb 17, 2018

12 of 13 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-verify
Details
cla/linuxfoundation sbezverk authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment