New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MountPropagation to beta. #59252

Merged
merged 1 commit into from Feb 6, 2018

Conversation

@jsafrane
Member

jsafrane commented Feb 2, 2018

What this PR does / why we need it:
MountPropagation is needed by CSI to be on by default.

Release note:

MountPropagation feature is now beta. As consequence, all volume mounts in containers are now "rslave" on Linux by default.

/sig storage
/assign @saad-ali @childsb

@jsafrane

This comment has been minimized.

Member

jsafrane commented Feb 2, 2018

/assign @thockin
for approval

@jsafrane

This comment has been minimized.

Member

jsafrane commented Feb 2, 2018

flake: #42644
/retest

@thockin

This comment has been minimized.

Member

thockin commented Feb 6, 2018

Is there really no issue that this should be xref'ed to?

/lgtm
/approve no-issue

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 6, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, thockin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 6, 2018

Automatic merge from submit-queue (batch tested with PRs 59373, 59379, 59252, 58295, 57786). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit b99bf20 into kubernetes:master Feb 6, 2018

13 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation jsafrane authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

dims pushed a commit to dims/kubernetes that referenced this pull request Mar 8, 2018

Merge pull request kubernetes#60682 from hanxiaoshuai/update0302
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

update Mount propagation version in comment

**What this PR does / why we need it**:
Mount propagation feature was moved to beta in PR [kubernetes#59252](kubernetes#59252 so update the comment.
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes#60657 

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

k8s-publishing-bot added a commit to kubernetes/api that referenced this pull request Mar 8, 2018

Merge pull request #60682 from hanxiaoshuai/update0302
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

update Mount propagation version in comment

**What this PR does / why we need it**:
Mount propagation feature was moved to beta in PR [#59252](kubernetes/kubernetes#59252 so update the comment.
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #60657

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: a0844c17bfb964e3d1709784203e8404f790116c

k8s-publishing-bot added a commit to kubernetes/api that referenced this pull request Mar 8, 2018

Merge pull request #60682 from hanxiaoshuai/update0302
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

update Mount propagation version in comment

**What this PR does / why we need it**:
Mount propagation feature was moved to beta in PR [#59252](kubernetes/kubernetes#59252 so update the comment.
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #60657

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: a0844c17bfb964e3d1709784203e8404f790116c

sttts pushed a commit to sttts/api that referenced this pull request Mar 16, 2018

Merge pull request #60682 from hanxiaoshuai/update0302
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

update Mount propagation version in comment

**What this PR does / why we need it**:
Mount propagation feature was moved to beta in PR [#59252](kubernetes/kubernetes#59252 so update the comment.
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #60657

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: a0844c17bfb964e3d1709784203e8404f790116c

sttts pushed a commit to sttts/api that referenced this pull request Mar 16, 2018

Merge pull request #60682 from hanxiaoshuai/update0302
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

update Mount propagation version in comment

**What this PR does / why we need it**:
Mount propagation feature was moved to beta in PR [#59252](kubernetes/kubernetes#59252 so update the comment.
**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #60657

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

Kubernetes-commit: a0844c17bfb964e3d1709784203e8404f790116c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment