New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet: only register api source when connecting #59276

Merged
merged 1 commit into from Feb 7, 2018

Conversation

@roboll
Contributor

roboll commented Feb 2, 2018

What this PR does / why we need it:
before this change, an api source was always registered, even when there
was no kubeclient. this lead to some operations blocking waiting for
podConfig.SeenAllSources to pass, which it never would.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59275

Special notes for your reviewer:

Release note:

Fix the bug where kubelet in the standalone mode would wait for the update from the apiserver source.
kubelet: only register api source when connecting
before this change, an api source was always registered, even when there
was no kubeclient. this lead to some operations blocking waiting for
podConfig.SeenAllSources to pass, which it never would.
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 2, 2018

Hi @roboll. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roboll

This comment has been minimized.

Contributor

roboll commented Feb 2, 2018

/assign @tallclair

@timothysc

This comment has been minimized.

Member

timothysc commented Feb 7, 2018

/sig node

@timothysc

It generally /lgtm given your description of the problem, but the original code mod was part of a recommendation from @kubernetes/sig-node-pr-reviews

@timothysc timothysc added this to the v1.10 milestone Feb 7, 2018

@yujuhong

This comment has been minimized.

Contributor

yujuhong commented Feb 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 7, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roboll, yujuhong

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@yujuhong yujuhong modified the milestones: v1.10, v1.9 Feb 7, 2018

@yujuhong

This comment has been minimized.

Contributor

yujuhong commented Feb 7, 2018

@roboll could you also create a cherrypick PR to patch 1.9? Thanks!

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 7, 2018

[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete

@roboll @timothysc @yujuhong

Action required: This pull request requires label changes. If the required changes are not made within 2 days, the pull request will be moved out of the v1.9 milestone.

priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.

Help
@yujuhong

This comment has been minimized.

Contributor

yujuhong commented Feb 7, 2018

It generally /lgtm given your description of the problem, but the original code mod was part of a recommendation from @kubernetes/sig-node-pr-reviews

I think it's just a bug and/or oversight. Not sure whether this was recommended explicitly....

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 7, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 7, 2018

Automatic merge from submit-queue (batch tested with PRs 59276, 51042, 58973, 59377, 59472). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 4754575 into kubernetes:master Feb 7, 2018

6 of 13 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
pull-kubernetes-e2e-kops-aws Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce Job triggered.
Details
pull-kubernetes-node-e2e Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation roboll authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-unit Job succeeded.
Details

k8s-merge-robot added a commit that referenced this pull request Mar 1, 2018

Merge pull request #59512 from roboll/automated-cherry-pick-of-#59276-…
…upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #59276: kubelet: only register api source when connecting

Cherry pick of #59276 on release-1.9.

#59276: kubelet: only register api source when connecting
@k8s-cherrypick-bot

This comment has been minimized.

k8s-cherrypick-bot commented Mar 1, 2018

Commit found in the "release-1.9" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment