Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation failure of Pod priority when the feature is disabled #59291

Merged
merged 1 commit into from Feb 12, 2018

Conversation

Projects
None yet
5 participants
@bsalamat
Copy link
Contributor

bsalamat commented Feb 2, 2018

What this PR does / why we need it:
I learned that fields specified in the API should be silently ignored when the feature is disabled. This makes sense as downgrading a cluster would fail otherwise. This PR removes the validation logic that ensures Pod priority is not set when priority feature is disabled.

Special notes for your reviewer:

Release note:

Pod priority can be specified ins PodSpec even when the feature is disabled, but it will be effective only when the feature is enabled.

/sig scheduling
ref: #57471

@k8s-ci-robot k8s-ci-robot requested review from sttts and tallclair Feb 2, 2018

@bsalamat bsalamat changed the title Remove validation failure of Pod priority when the feauter is disabled Remove validation failure of Pod priority when the feature is disabled Feb 2, 2018

@tallclair

This comment has been minimized.

Copy link
Member

tallclair commented Feb 7, 2018

/lgtm

@bsalamat

This comment has been minimized.

Copy link
Contributor Author

bsalamat commented Feb 8, 2018

@liggitt Could you please take a look at this one too? Thanks!

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 12, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 12, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, liggitt, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Feb 12, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Feb 12, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 245ca8e into kubernetes:master Feb 12, 2018

13 of 14 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation bsalamat authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce-canary Skipped
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@bsalamat bsalamat deleted the bsalamat:fix_validation branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.