Join GitHub today
Remove controller-manager --service-sync-period flag #59359
What this PR does / why we need it:
Which issue(s) this PR fixes
This flag was disconnected at least as far back as 1.4. I'll leave this open for a couple days in case someone can find a way it could have worked in the past year and change. Lacking that, I plan to merge on Wednesday.
@khenidak please squash into two commits: one for work, one for generated.
/lgtm. Please make sure to clean up all of cmd/kube-controller-manager/app/options/options_test.go.
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
the e2e is flaky
I will try later tonight.