New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certs: allow cert controller to delete csrs #59375

Merged
merged 1 commit into from Feb 6, 2018

Conversation

Projects
None yet
4 participants
@mikedanese
Member

mikedanese commented Feb 5, 2018

This should have been changed as part of #51840.

Fixes #59351

Fix RBAC role for certificate controller to allow cleaning.
certs: allow cert controller to delete csrs
This should have been changed as part of #51840.
@liggitt

This comment has been minimized.

Member

liggitt commented Feb 5, 2018

/lgtm

Probably want to cherry pick this to allow cleanup of expired CSR's

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 5, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mikedanese

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mikedanese

This comment has been minimized.

Member

mikedanese commented Feb 5, 2018

I will start cherrypicking.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 6, 2018

Automatic merge from submit-queue (batch tested with PRs 55986, 59375, 59334, 59348, 58027). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 6c8d4d3 into kubernetes:master Feb 6, 2018

13 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation mikedanese authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@mikedanese mikedanese deleted the mikedanese:csr-delete branch Feb 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment