New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler - not able to read from config file if configmap is not found #59386

Merged
merged 1 commit into from Feb 6, 2018

Conversation

Projects
None yet
5 participants
@ravisantoshgudimetla
Contributor

ravisantoshgudimetla commented Feb 6, 2018

What this PR does / why we need it:
As of now, we are not able to read config file if configmap is not present. The only way to make it work is to enable legacy mode which should not be the case.
xref: https://bugzilla.redhat.com/show_bug.cgi?id=1540785
Release note:

Scheduler should be able to read from config file if configmap is not present.

/cc @bsalamat @ironcladlou

@ravisantoshgudimetla

This comment has been minimized.

Contributor

ravisantoshgudimetla commented Feb 6, 2018

/sig scheduling

@k82cn

This comment has been minimized.

Member

k82cn commented Feb 6, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@@ -214,7 +214,7 @@ func (o *Options) applyDeprecatedHealthzPortToConfig() {
// 3. --algorithm-provider to use a named algorithm provider.
func (o *Options) applyDeprecatedAlgorithmSourceOptionsToConfig() {
switch {
case o.useLegacyPolicyConfig:
case o.useLegacyPolicyConfig || (len(o.policyConfigFile) > 0 && o.policyConfigMapName == ""):

This comment has been minimized.

@bsalamat

bsalamat Feb 6, 2018

Contributor

s/o.policyConfigMapName == ""/len(o.policyConfigMapName) == 0/

This comment has been minimized.

@ravisantoshgudimetla

ravisantoshgudimetla Feb 6, 2018

Contributor

@bsalamat - Shall I create another PR for this?

This comment has been minimized.

@bsalamat

bsalamat Feb 6, 2018

Contributor

@ravisantoshgudimetla No, thers is no need to send another PR.
Thanks for checking.

This comment has been minimized.

@k82cn

k82cn Feb 7, 2018

Member

Ops :)

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 6, 2018

Automatic merge from submit-queue (batch tested with PRs 59165, 59386). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit f611b32 into kubernetes:master Feb 6, 2018

13 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation ravisantoshgudimetla authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@ravisantoshgudimetla

This comment has been minimized.

Contributor

ravisantoshgudimetla commented Feb 6, 2018

Thanks @k82cn for LGTM.. @bsalamat Shall I create another PR for the change you suggested or do you think this is good enough?

openshift-merge-robot added a commit to openshift/origin that referenced this pull request Feb 26, 2018

Merge pull request #18475 from ravisantoshgudimetla/fix-scheduler-con…
…fig-flag

Automatic merge from submit-queue.

UPSTREAM: 59386: Scheduler - not able to read from config file if configmap not found

Scheduler is not able to read from config file if configmap is not found. 

Upstream PR: kubernetes/kubernetes#59386

xref: https://bugzilla.redhat.com/show_bug.cgi?id=1540785

/cc @aveshagarwal  @sjenning

openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Feb 26, 2018

Merge pull request kubernetes#18475 from ravisantoshgudimetla/fix-sch…
…eduler-config-flag

Automatic merge from submit-queue.

UPSTREAM: 59386: Scheduler - not able to read from config file if configmap not found

Scheduler is not able to read from config file if configmap is not found.

Upstream PR: kubernetes#59386

xref: https://bugzilla.redhat.com/show_bug.cgi?id=1540785

/cc @aveshagarwal  @sjenning

Origin-commit: a1c2561ddfcb6c8d54c0188317dfabcbd25eca62

@ravisantoshgudimetla ravisantoshgudimetla deleted the ravisantoshgudimetla:fix-scheduler-config-file branch Feb 27, 2018

openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Feb 27, 2018

Merge pull request kubernetes#18475 from ravisantoshgudimetla/fix-sch…
…eduler-config-flag

Automatic merge from submit-queue.

UPSTREAM: 59386: Scheduler - not able to read from config file if configmap not found

Scheduler is not able to read from config file if configmap is not found.

Upstream PR: kubernetes#59386

xref: https://bugzilla.redhat.com/show_bug.cgi?id=1540785

/cc @aveshagarwal  @sjenning

Origin-commit: a1c2561ddfcb6c8d54c0188317dfabcbd25eca62

openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Mar 23, 2018

Merge pull request kubernetes#18475 from ravisantoshgudimetla/fix-sch…
…eduler-config-flag

Automatic merge from submit-queue.

UPSTREAM: 59386: Scheduler - not able to read from config file if configmap not found

Scheduler is not able to read from config file if configmap is not found.

Upstream PR: kubernetes#59386

xref: https://bugzilla.redhat.com/show_bug.cgi?id=1540785

/cc @aveshagarwal  @sjenning

Origin-commit: a1c2561ddfcb6c8d54c0188317dfabcbd25eca62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment