Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ephemeral Containers to the Kubernetes core API #59416

Merged
merged 3 commits into from Jul 22, 2019

Conversation

@verb
Copy link
Contributor

commented Feb 6, 2018

What this PR does / why we need it: This updates the Kubernetes API as described in kubernetes/community#1269 to add Ephemeral Containers. The new subresource of pod is hidden behind an alpha feature flag.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
WIP #27140
WIP #10834

Special notes for your reviewer:
/assign @yujuhong
/cc @liggitt @dchen1107 @smarterclayton @lavalamp

Release note:

NONE

Follow Up PRs:
I've split some topics to separate PRs to reduce load on API reviewer. Once this API change is submitted I'll rebase these and find additional reviewers:

  • #79216: Adds integration tests for ephemeral containers API
  • #79614: Improve ephemeral containers API documentation

To Do:

  • Check for code iterating containers that should be updated to include ephemeral containers
  • Resolve question about whether it would be better to copy Container fields to EphemeralContainer rather than inlining.
  • Implement a test to make sure fields in Container and EphemeralContainer remain in sync.

@verb verb force-pushed the verb:debug-api branch 2 times, most recently from 1b53e8a to e27bc24 Feb 7, 2018

@verb verb changed the title Add Ephemeral Containers to the Kubernetes core API WIP: Add Ephemeral Containers to the Kubernetes core API Feb 15, 2018

@verb verb force-pushed the verb:debug-api branch from e27bc24 to b665ecd Apr 30, 2018

@verb verb force-pushed the verb:debug-api branch 2 times, most recently from 5c00903 to ede1fb2 Apr 30, 2018

@verb verb changed the title WIP: Add Ephemeral Containers to the Kubernetes core API Add Ephemeral Containers to the Kubernetes core API Apr 30, 2018

@verb verb force-pushed the verb:debug-api branch from ede1fb2 to add8963 May 15, 2018

@verb verb force-pushed the verb:debug-api branch from add8963 to bfbb298 May 15, 2018

@yujuhong

This comment has been minimized.

Copy link
Member

commented May 16, 2018

Need api reviewers/approvers.

@liggitt @lavalamp @smarterclayton does anyone of you have time to review?

@verb verb force-pushed the verb:debug-api branch from 32374b2 to 4b5160c Jun 28, 2019

@verb

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

Weird, the failing test isn't even in my branch. I guess bazel tests are run from head?

@verb verb force-pushed the verb:debug-api branch 2 times, most recently from 7e2d87b to d378931 Jun 28, 2019

@verb verb force-pushed the verb:debug-api branch 2 times, most recently from 8423dc3 to 3d9a12d Jul 2, 2019

@verb

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

/retest

@verb verb force-pushed the verb:debug-api branch from 3d9a12d to 0c78220 Jul 16, 2019

@dims

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

/retest

@verb verb force-pushed the verb:debug-api branch from 0c78220 to a528bd9 Jul 19, 2019

@verb verb force-pushed the verb:debug-api branch from a528bd9 to 4a753c7 Jul 22, 2019

@@ -2843,6 +2843,17 @@ type PodSpec struct {
// +patchMergeKey=name
// +patchStrategy=merge
Containers []Container `json:"containers" patchStrategy:"merge" patchMergeKey:"name" protobuf:"bytes,2,rep,name=containers"`
// EphemeralContainers is the list of ephemeral containers that run in this pod. Ephemeral containers

This comment has been minimized.

Copy link
@smarterclayton

smarterclayton Jul 22, 2019

Contributor

Note that the name should be ephemeralContainers in Godoc when referencing the field. I'm ok with this being a follow up if there's nothing else in this pass.

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

/lgtm
/approve

Follow up PRs already identified, I'll do a godoc pass before we hit freeze.

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 22, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, verb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7e6b70f into kubernetes:master Jul 22, 2019

22 of 23 checks passed

tide Not mergeable.
Details
cla/linuxfoundation verb authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
@saschagrunert

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Hey @verb 👋, do you think it would be possible to change the release notes entry at this PR to document the user facing changes? It is currently marked as NONE but we definitely want to add this one to the notes. :)

@verb

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Hi @saschagrunert, Right now it's just a disconnected API, but #59484 updates the kubelet to launch ephemeral containers so I thought it'd be a good place for release notes. I expect it to merge in time for 1.16. Would that work?

@saschagrunert

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Hi @saschagrunert, Right now it's just a disconnected API, but #59484 updates the kubelet to launch ephemeral containers so I thought it'd be a good place for release notes. I expect it to merge in time for 1.16. Would that work?

That would be wonderful, thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.