New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated /proxy paths #59884

Merged
merged 2 commits into from Feb 21, 2018

Conversation

@mikedanese
Member

mikedanese commented Feb 14, 2018

These were deprecated in v1.2.
ref #59885

kube-apiserver: the root /proxy paths have been removed (deprecated since v1.2). Use the /proxy subresources on objects that support HTTP proxying.

@kubernetes/sig-api-machinery-api-reviews

@liggitt

This comment has been minimized.

Member

liggitt commented Feb 14, 2018

vendor/k8s.io/apiserver/pkg/endpoints/installer.go:243:30: isRedirector declared and not used

intent lgtm, likely requires test updates and generated API doc updates

@mikedanese mikedanese self-assigned this Feb 14, 2018

@k8s-ci-robot k8s-ci-robot added size/L and removed size/S labels Feb 14, 2018

@mikedanese

This comment has been minimized.

Member

mikedanese commented Feb 14, 2018

I should probably get rid of rest.Redirector while I'm in here. New proxy storages implement rest.Connector

@liggitt

This comment has been minimized.

Member

liggitt commented Feb 20, 2018

/lgtm

mikedanese added some commits Feb 14, 2018

remove deprecated /proxy paths
These were depercated in v1.2.
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 20, 2018

@mikedanese: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross 1ab6c82 link /test pull-kubernetes-cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikedanese

This comment has been minimized.

Member

mikedanese commented Feb 20, 2018

To review removal of conformance tests testing old proxy path:

/assign @smarterclayton

@mikedanese mikedanese added this to the v1.10 milestone Feb 21, 2018

@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Feb 21, 2018

/approve

Conformance removal is acceptable because these paths have been deprecated for 8 releases.

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mikedanese, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikedanese mikedanese added the lgtm label Feb 21, 2018

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 21, 2018

Automatic merge from submit-queue (batch tested with PRs 58716, 59977, 59316, 59884, 60117). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 687c651 into kubernetes:master Feb 21, 2018

13 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation mikedanese authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@mikedanese mikedanese deleted the mikedanese:remove-deprecated-proxy branch Feb 22, 2018

@bgrant0607

This comment has been minimized.

Member

bgrant0607 commented Feb 22, 2018

LGTM, thanks

CaoShuFeng added a commit to CaoShuFeng/kubernetes.github.io that referenced this pull request Mar 29, 2018

@liggitt liggitt referenced this pull request Apr 8, 2018

Closed

Delete legacy proxy path #10045

k8s-ci-robot added a commit to kubernetes/website that referenced this pull request Apr 9, 2018

zacharysarah added a commit to kubernetes/website that referenced this pull request Apr 16, 2018

@andresmgot andresmgot referenced this pull request Apr 25, 2018

Closed

run function gives 500 #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment