New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ConfigOK to KubeletConfigOk #59905

Merged
merged 1 commit into from Feb 15, 2018

Conversation

@mtaufen
Contributor

mtaufen commented Feb 15, 2018

This is a more accurate name for the condition, as it describes the
status of the Kubelet's configuration.

Also cleans up capitalization of internal names.

The ConfigOK node condition has been renamed to KubeletConfigOk.
Rename ConfigOK to KubeletConfigOk
This is a more accurate name for the condition, as it describes the
status of the Kubelet's configuration.

Also cleans up capitalization of internal names.
@dashpole

This comment has been minimized.

Contributor

dashpole commented Feb 15, 2018

Good stuff. While it wasn't necessarily ambiguous whose config it was referring to, I think this change makes it even more obvious.
Is this considered an API change? I guess Dynamic Kubelet config is still Alpha, so it wouldn't matter anyways.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 15, 2018

@mtaufen

This comment has been minimized.

Contributor

mtaufen commented Feb 15, 2018

Yeah, should be ok since it's alpha.

@dchen1107

This comment has been minimized.

Member

dchen1107 commented Feb 15, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107, mtaufen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 15, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 15, 2018

Automatic merge from submit-queue (batch tested with PRs 59353, 59905, 53833). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit b099e91 into kubernetes:master Feb 15, 2018

7 of 13 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-bazel-test
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job triggered.
Details
pull-kubernetes-e2e-kops-aws Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation mtaufen authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment