New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cadvisor godeps to v0.29.0 and ignore per-cpu metrics #60106

Merged
merged 1 commit into from Feb 23, 2018

Conversation

@dashpole
Contributor

dashpole commented Feb 20, 2018

What this PR does / why we need it:
Updates the cAdvisor dependency to the cAdvisor release associated with the kubernetes 1.10 release.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #60052

Special notes for your reviewer:
This PR also adds per-cpu metrics to the ignoreMetrics list. This is a new metric that can be ignored in the most recent cAdvisor release.
The reason for not collecting per-cpu metrics is that it can cause severe scalability issues.
For example, if using a 128 core machine, and running 100 containers, we have 12800 different streams of metrics just for per-cpu metrics which cAdvisor needs to process and transmit.
Additionally, per-cpu metrics are not used by any kubernetes components, and if a user needs these metrics, they can run cAdvisor as a daemonset.

Release note:

Disable per-cpu metrics by default for scalability.
Fix inaccurate disk usage monitoring of overlayFs.
Retry docker connection on startup timeout to avoid permanent loss of metrics.

/assign @dchen1107

@dashpole

This comment has been minimized.

Contributor

dashpole commented Feb 20, 2018

/sig node
/priority critical-urgent
/kind bug
(since most changes here are actually bug-fixes)

@dchen1107

This comment has been minimized.

Member

dchen1107 commented Feb 21, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 21, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot k8s-merge-robot removed the lgtm label Feb 22, 2018

@dashpole

This comment has been minimized.

Contributor

dashpole commented Feb 22, 2018

re-adding lgtm after another rebase based on #60106 (comment)

@dashpole dashpole added the lgtm label Feb 22, 2018

@dashpole

This comment has been minimized.

Contributor

dashpole commented Feb 22, 2018

/retest

1 similar comment
@dashpole

This comment has been minimized.

Contributor

dashpole commented Feb 22, 2018

/retest

@fejta-bot

This comment has been minimized.

fejta-bot commented Feb 23, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

fejta-bot commented Feb 23, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 23, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 23, 2018

@dashpole: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test 65394fe link /test pull-kubernetes-bazel-test
pull-kubernetes-unit 65394fe link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 23, 2018

Automatic merge from submit-queue (batch tested with PRs 60106, 59510, 60263, 60063, 59088). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 6af0768 into kubernetes:master Feb 23, 2018

10 of 13 checks passed

pull-kubernetes-bazel-test Job failed.
Details
pull-kubernetes-unit Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-bazel-test
Details
cla/linuxfoundation dashpole authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@dashpole dashpole deleted the dashpole:cadvisor_godep branch Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment