New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate kubectl scale job #60139

Merged
merged 2 commits into from Feb 22, 2018

Conversation

Projects
None yet
5 participants
@soltysh
Contributor

soltysh commented Feb 21, 2018

What this PR does / why we need it:
With the generic scaler (#58298) the only problem is job and as discussed in #58468 (comment) and during SIG CLI we've agreed that scaling jobs was a mistake we need to revert.
This PR deprecates scale command for jobs, only.

/assign @deads2k @pwittrock

Release note:

Deprecate kubectl scale jobs (only jobs). 
@deads2k

This comment has been minimized.

Contributor

deads2k commented Feb 21, 2018

This matches the discussion in sig-cli.

/lgtm

@@ -146,6 +147,10 @@ func RunScale(f cmdutil.Factory, out io.Writer, cmd *cobra.Command, args []strin
}
mapping := info.ResourceMapping()
if mapping.Resource == "jobs" {
glog.Warningf("%s scale job is DEPRECATED and will be removed in a future version.", cmd.Parent().Name())

This comment has been minimized.

@deads2k

deads2k Feb 21, 2018

Contributor

we normally use fmt.fprintf(stderr to avoid irrelevant line numbers.

This comment has been minimized.

@soltysh

soltysh Feb 21, 2018

Contributor

That's what I had originally, but then I found this cherry. Although I'm fine fixing the other one as well to use fmt.Fprintf

@deads2k

This comment has been minimized.

Contributor

deads2k commented Feb 21, 2018

/hold

fix up the printing

soltysh added some commits Feb 21, 2018

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Feb 21, 2018

@k8s-merge-robot k8s-merge-robot removed the lgtm label Feb 21, 2018

@soltysh

This comment has been minimized.

Contributor

soltysh commented Feb 21, 2018

@deads2k fixed the printing and updated printDeprecationWarning accordingly

@deads2k

This comment has been minimized.

Contributor

deads2k commented Feb 22, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 22, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 22, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh

This comment has been minimized.

Contributor

soltysh commented Feb 22, 2018

The printing was fixed, I'm guessing David forgot to :
/hold cancel

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 22, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 22, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 39c7e92 into kubernetes:master Feb 22, 2018

12 of 13 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-kops-aws
Details
cla/linuxfoundation soltysh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@soltysh soltysh deleted the soltysh:deprecate_scale_job branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment