New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding metrics server #60174

Merged
merged 1 commit into from Apr 2, 2018

Conversation

Projects
None yet
6 participants
@hyperbolic2346
Contributor

hyperbolic2346 commented Feb 22, 2018

What this PR does / why we need it:
Adds support for the metrics server in the kubernetes-master charm. This allows the use of a horizontal pod autoscaler.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
juju-solutions/bundle-canonical-kubernetes#484
Special notes for your reviewer:
Needs to go in after juju-solutions/cdk-addons#28
Release note:

kubernetes-master charm now supports metrics server for horizontal pod autoscaler.
@BenTheElder

This comment has been minimized.

Member

BenTheElder commented Mar 1, 2018

/ok-to-test

@BenTheElder

This comment has been minimized.

Member

BenTheElder commented Mar 1, 2018

you should probably assign someone from cluster/juju/OWNERS, the current set of reviewers on this PR are assigned to far too many PRs :^)

@hyperbolic2346

This comment has been minimized.

Contributor

hyperbolic2346 commented Mar 1, 2018

api_opts['proxy-client-cert-file'] = client_cert_path
api_opts['proxy-client-key-file'] = client_key_path
api_opts['enable-aggregator-routing'] = 'true'
api_opts['client-ca-file'] = ca_cert_path

This comment has been minimized.

@Cynerva

Cynerva Mar 14, 2018

Contributor

Can we just always set client-ca-file (and maybe the rest of these) regardless of the configuration of enable-metrics? Would it hurt anything?

I'm asking because, if we always set client-ca-file, it would provide a convenient fix for juju-solutions/bundle-canonical-kubernetes#515.

This comment has been minimized.

@hyperbolic2346

hyperbolic2346 Mar 14, 2018

Contributor

@Cynerva I have no problem with that, I was just trying to reduce the scope of the change to only have an impact when metrics were enabled. Is this a request to make that change or just start a conversation?

This comment has been minimized.

@Cynerva

Cynerva Mar 14, 2018

Contributor

Just starting a conversation, sorry for not being clear on that. I don't think anything needs to change in this PR, it looks solid and I don't want to expand the scope of it without good reason. We can address juju-solutions/bundle-canonical-kubernetes#515 in a standalone PR later :)

@Cynerva

This comment has been minimized.

Contributor

Cynerva commented Mar 14, 2018

This LGTM, but we need to get juju-solutions/cdk-addons#28 merged before we can let this one go out.

@Cynerva

This comment has been minimized.

Contributor

Cynerva commented Mar 27, 2018

/lgtm

@ktsakalozos

This comment has been minimized.

Collaborator

ktsakalozos commented Apr 2, 2018

/lgtm

@ktsakalozos

This comment has been minimized.

Collaborator

ktsakalozos commented Apr 2, 2018

/retest

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, hyperbolic2346, ktsakalozos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ktsakalozos

This comment has been minimized.

Collaborator

ktsakalozos commented Apr 2, 2018

/test pull-kubernetes-typecheck

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 2, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 2, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 2550bab into kubernetes:master Apr 2, 2018

13 of 14 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation hyperbolic2346 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment