Adding metrics server #60174
Adding metrics server #60174
Conversation
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
you should probably assign someone from cluster/juju/OWNERS, the current set of reviewers on this PR are assigned to far too many PRs :^) |
|
/assign @Cynerva @ktsakalozos |
| api_opts['proxy-client-cert-file'] = client_cert_path | ||
| api_opts['proxy-client-key-file'] = client_key_path | ||
| api_opts['enable-aggregator-routing'] = 'true' | ||
| api_opts['client-ca-file'] = ca_cert_path |
There was a problem hiding this comment.
Can we just always set client-ca-file (and maybe the rest of these) regardless of the configuration of enable-metrics? Would it hurt anything?
I'm asking because, if we always set client-ca-file, it would provide a convenient fix for https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/515.
There was a problem hiding this comment.
@Cynerva I have no problem with that, I was just trying to reduce the scope of the change to only have an impact when metrics were enabled. Is this a request to make that change or just start a conversation?
There was a problem hiding this comment.
Just starting a conversation, sorry for not being clear on that. I don't think anything needs to change in this PR, it looks solid and I don't want to expand the scope of it without good reason. We can address https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/515 in a standalone PR later :)
|
This LGTM, but we need to get charmed-kubernetes/cdk-addons#28 merged before we can let this one go out. |
|
/lgtm |
k8s-ci-robot
added
lgtm
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cynerva, hyperbolic2346, ktsakalozos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kubernetes-typecheck |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Adds support for the metrics server in the kubernetes-master charm. This allows the use of a horizontal pod autoscaler.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/484
Special notes for your reviewer:
Needs to go in after charmed-kubernetes/cdk-addons#28
Release note: