Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Disable mount propagation for windows containers #60275
What this PR does / why we need it:
Windows containers don't support mount propagation. This PR disables it for windows containers.
Without this PR, windows containers creation would fail with error:
Error: Error response from daemon: invalid bind mount spec "c:\var\lib\kubelet\pods\a260a7c4-1852-11e8-bb1d-000d3a19c1da\volumes\kubernetes.io
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
I approved this PR , but please also modify the documentation at https://kubernetes.io/docs/getting-started-guides/windows/ to add this at the bottom under known limitations
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing