Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
expunge the word 'manifest' from Kubelet's config API #60314
The word 'manifest' technically refers to a container-group specification
I left the flags alone, since they're deprecated anyway.
I changed a few var names in files I touched too, but this PR is the
requested review from
Feb 23, 2018
This was referenced
Feb 23, 2018
PodPath is a little bit vague. Maybe
IIRC "static" pod is defined to be a pod that lacks certain features - e.g. it's visible in the API server but not possible to modify/manage via the API. Being specified via a file is how you get a "static" pod today, but file-based pods don't necessarily have to be "static." If we ever improve on this for pods specified via local files, I'm not sure we should keep using the word "static" to describe them.
(at least this is how I've seen it used, though technically we report these as "mirror" pods in the API server, the association is pretty strong... so maybe I'm off base and static has really meant "file" all along)
I don't think the concept of pods specified via local files can go away. I'm less sure about static pods.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing