New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet: fix bug where character device is not recognized #60440

Merged
merged 1 commit into from Feb 27, 2018

Conversation

@andrewsykim
Member

andrewsykim commented Feb 26, 2018

What this PR does / why we need it:
Fixes a bug where character devices are not recognized by the kubelet because we return FileTypeBlockDev instead of FileTypeCharDev.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related issue: #5607

Special notes for your reviewer:
Kubelet event for bug: #5607 (comment)

Warning		FailedMount		MountVolume.SetUp failed for volume "dev-fuse" : hostPath type check failed: /dev/fuse is not a character device

Commit where bug was introduced: 57ead48
Release note:

Fixes a bug where character devices are not recongized by the kubelet

@k8s-ci-robot k8s-ci-robot requested review from jsafrane and saad-ali Feb 26, 2018

@andrewsykim andrewsykim changed the title from fix bug where character devices are not recognized to kubelet: fix bug where character device is not recognized Feb 26, 2018

@andrewsykim

This comment has been minimized.

Member

andrewsykim commented Feb 26, 2018

cc @dixudx

@saad-ali

This comment has been minimized.

Member

saad-ali commented Feb 26, 2018

/lgtm
/approve

This should be cherry picked to affected branches.

@saad-ali

This comment has been minimized.

Member

saad-ali commented Feb 26, 2018

/test pull-kubernetes-unit
/test pull-kubernetes-verify

@k8s-cherrypick-bot

This comment has been minimized.

k8s-cherrypick-bot commented Feb 26, 2018

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@andrewsykim

This comment has been minimized.

Member

andrewsykim commented Feb 26, 2018

Had to rebase to get a test fixed in master

/test pull-kubernetes-verify

@k8s-merge-robot k8s-merge-robot removed the lgtm label Feb 26, 2018

@jsafrane

This comment has been minimized.

Member

jsafrane commented Feb 27, 2018

/lgtm

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, jsafrane, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane

This comment has been minimized.

Member

jsafrane commented Feb 27, 2018

/retest

@dixudx

This comment has been minimized.

Member

dixudx commented Feb 27, 2018

My fault. Thanks @andrewsykim for fixing this.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 27, 2018

Automatic merge from submit-queue (batch tested with PRs 60433, 59982, 59128, 60243, 60440). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit e99ec24 into kubernetes:master Feb 27, 2018

13 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation andrewsykim authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@andrewsykim

This comment has been minimized.

Member

andrewsykim commented Feb 27, 2018

Will cherry-pick this into v1.9 today

k8s-merge-robot added a commit that referenced this pull request Mar 23, 2018

Merge pull request #60510 from andrewsykim/automated-cherry-pick-of-#…
…60440-origin-release-1.9

Automatic merge from submit-queue.

Cherry pick 60440 to release v1.9

Cherry pick of #60440

```release-note
kubelet: fix bug where character devices are not recognized
```

cc @saad-ali @jsafrane @dixudx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment