New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for LeaderElect for kube-scheduler #60524

Merged
merged 1 commit into from Mar 1, 2018

Conversation

@dims
Member

dims commented Feb 27, 2018

What this PR does / why we need it:

kube-controller-manager defaults --leader-elect to true. We should
do the same for kube-scheduler. kube-scheduler used to have this
set to true, but it got lost during refactoring:

efb2bb7

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59729

Special notes for your reviewer:

Release note:

kube-scheduler: restores default leader election behavior. leader-elect command line parameter should "true"
Temporary fix for LeaderElect for kube-scheduler
kube-controller-manager defaults --leader-elect to true. We should
do the same for kube-scheduler. kube-scheduler used to have this
set to true, but it got lost during refactoring:

efb2bb7
@dims

This comment has been minimized.

Member

dims commented Feb 27, 2018

/assign @liggitt
/assign @mtaufen

@liggitt

This comment has been minimized.

Member

liggitt commented Feb 27, 2018

@liggitt

This comment has been minimized.

Member

liggitt commented Feb 27, 2018

/lgtm

needs cherry-pick to 1.9, right?

@dims

This comment has been minimized.

Member

dims commented Feb 27, 2018

@liggitt yep, here it is #60526

@mtaufen

This comment has been minimized.

Contributor

mtaufen commented Feb 27, 2018

/retest

@mtaufen

This comment has been minimized.

Contributor

mtaufen commented Feb 27, 2018

/status approve-for-milestone

@bsalamat

This comment has been minimized.

Contributor

bsalamat commented Feb 27, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@resouer

This comment has been minimized.

Member

resouer commented Feb 28, 2018

@dims We need to do cherry pick now

@dims

This comment has been minimized.

Member

dims commented Feb 28, 2018

@resouer the cherry pick is here #60526

@mtaufen

This comment has been minimized.

Contributor

mtaufen commented Feb 28, 2018

This isn't merging because it doesn't have status/approved-for-milestone.
Someone with permission to do that needs to add the label.

@liggitt

This comment has been minimized.

Member

liggitt commented Feb 28, 2018

this is a bugfix that is required for 1.10 and in process to be backported to 1.9
/status approved-for-milestone

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 28, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@bsalamat @dims @liggitt @mtaufen

Pull Request Labels
  • sig/scheduling: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 28, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@BenTheElder

This comment has been minimized.

Member

BenTheElder commented Mar 1, 2018

/test pull-kubernetes-bazel-build
/test pull-kubernetes-bazel-test

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 1, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@mtaufen

This comment has been minimized.

Contributor

mtaufen commented Mar 1, 2018

/retest

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 1, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@dims

This comment has been minimized.

Member

dims commented Mar 1, 2018

/test pull-kubernetes-integration

@BenTheElder

This comment has been minimized.

Member

BenTheElder commented Mar 1, 2018

#60614
/retest

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 1, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 1, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 58731ae into kubernetes:master Mar 1, 2018

13 of 14 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Context retired. Status moved to "pull-kubernetes-integration".
pull-kubernetes-verify Job succeeded.
Details
@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 16, 2018

Commit found in the "release-1.9" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@davidopp

This comment has been minimized.

Member

davidopp commented Mar 20, 2018

/approve

jpbetz added a commit that referenced this pull request Mar 20, 2018

Merge pull request #60526 from dims/automated-cherry-pick-of-#60524-u…
…pstream-release-1.9

Automated cherry pick of #60524: Temporary fix for LeaderElect for kube-scheduler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment