New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable IPVS feature gateway by default since it's already beta #60540

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
5 participants
@m1093782566
Member

m1093782566 commented Feb 28, 2018

What this PR does / why we need it:

Per #60501, kubeadm init doesn't support the --feature-gates=SupportIPVSProxyMode=true flag anymore since IPVS is in beta and not alpha anymore. We should enable IPVS feature gateway by default to make kubeadm set up IPVS proxy properly.

Which issue(s) this PR fixes:
Fixes #60543

Special notes for your reviewer:

Release note:

Enable IPVS feature gateway by default
@m1093782566

This comment has been minimized.

Member

m1093782566 commented Feb 28, 2018

/assign @thockin

@thockin

This comment has been minimized.

Member

thockin commented Feb 28, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 28, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Feb 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1093782566, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@m1093782566

This comment has been minimized.

Member

m1093782566 commented Feb 28, 2018

@jdumars for milestone status approved since it's a bug fix.

@jdumars jdumars added this to the v1.10 milestone Feb 28, 2018

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Feb 28, 2018

Automatic merge from submit-queue (batch tested with PRs 58171, 58036, 60540). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit f89d0fa into kubernetes:master Feb 28, 2018

13 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation m1093782566 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@m1093782566 m1093782566 deleted the m1093782566:ipvs-beta branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment