Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use go1.10.1 #60597

Merged
merged 1 commit into from Apr 2, 2018

Conversation

@cblecker
Copy link
Member

cblecker commented Feb 28, 2018

What this PR does / why we need it:
Update to use go1.10.1

Release note:

Update to use go1.10.1

@cblecker cblecker added this to the v1.11 milestone Feb 28, 2018

@k8s-ci-robot k8s-ci-robot requested review from luxas and spxtr Feb 28, 2018

@cblecker cblecker removed request for luxas and spxtr Feb 28, 2018

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Feb 28, 2018

/hold

basically LGTM. I'm going to wait and see if the tests explode, and if not, I will build the crossbuild image.

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Feb 28, 2018

it looks like #60373 might be a blocker?

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Mar 1, 2018

I don't think so.. I checked out that PR locally, and it didn't fix this particular failure.
Created #60598 for it.

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Mar 1, 2018

Okay, so we can probably hold on building the images yet. Looks like we may need to wait for an upstream golang fix based on @liggitt's diagnosis here: #60598 (comment)

@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Mar 20, 2018

/cc
we'll want to upgrade some test-infra images too.

urls = ["https://github.com/bazelbuild/rules_go/archive/ff7e3364d9383cf14155f8c2efc87218d07eb03b.tar.gz"],
sha256 = "1cac93a87939915f26844b92df4f6b946f68707a4830a489c3382223e7913fbd",
strip_prefix = "rules_go-78c989a6002e1ee28f3a18e3d8d2787feb0fe3a6",
urls = ["https://github.com/bazelbuild/rules_go/archive/78c989a6002e1ee28f3a18e3d8d2787feb0fe3a6.tar.gz"],

This comment has been minimized.

@ixdy

ixdy Mar 30, 2018

Member

maybe we should just switch to the release tarball directly? i.e. https://github.com/bazelbuild/rules_go/releases/download/0.10.2/rules_go-0.10.2.tar.gz.

this won't need the strip_prefix, either.

$ sha256sum rules_go-0.10.2.tar.gz 
4b2c61795ac2eefcb28f3eb8e1cb2d8fb3c2eafa0f6712473bc5f93728f38758  rules_go-0.10.2.tar.gz
@@ -38,15 +38,15 @@ http_archive(

load("@bazel_skylib//:lib.bzl", "versions")

versions.check(minimum_bazel_version = "0.10.0")
versions.check(minimum_bazel_version = "0.10.1")

This comment has been minimized.

@ixdy

ixdy Mar 30, 2018

Member

is there a particular need for 0.10.1?

This comment has been minimized.

@cblecker

cblecker Mar 30, 2018

Author Member

Oops. Just a case of version number blur when updating stuff.

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Mar 30, 2018

@ixdy Bazel test is green 🎉! We should be good to push images.

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Mar 30, 2018

$ docker pull golang:1.10.1
Error response from daemon: manifest for golang:1.10.1 not found

???

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Mar 30, 2018

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Mar 30, 2018

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Mar 31, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@cblecker @ixdy

Pull Request Labels
  • sig/release: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/feature: New functionality.
Help
@BenTheElder

This comment has been minimized.

Copy link
Member

BenTheElder commented Apr 2, 2018

/retest

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 2, 2018

@BenTheElder the k8s.gcr.io/kube-cross:v1.10.1-1 image needs to be pushed first before the cross/verify jobs will pass.

@ixdy Looks like golang:1.10.1 is available now.

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Apr 2, 2018

image built and pushed.

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 2, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Apr 2, 2018

something weird is going on; the new tag appears under gcr.io/google-containers/kube-cross, but not k8s.gcr.io/kube-cross. I'm hoping it's an eventual-consistency thing that'll work itself out in a little bit.

@ixdy

This comment has been minimized.

Copy link
Member

ixdy commented Apr 2, 2018

/retest

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 2, 2018

/hold cancel
If this goes green, it should be clear to merge.

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Apr 2, 2018

/test pull-kubernetes-verify

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Apr 2, 2018

Automatic merge from submit-queue (batch tested with PRs 61096, 61955, 61542, 60597). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 3b82ea6 into kubernetes:master Apr 2, 2018

14 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation cblecker authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@BenTheElder BenTheElder referenced this pull request Apr 2, 2018

Closed

upgrade to go 1.10.1 #7513

@cblecker cblecker deleted the cblecker:go-go-go-one-dot-ten branch Apr 2, 2018

k8s-github-robot pushed a commit that referenced this pull request Apr 24, 2018

Kubernetes Submit Queue
Merge pull request #63046 from cblecker/go-go-minimum
Automatic merge from submit-queue (batch tested with PRs 63046, 62925, 63014). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Bump minimum required go version to 1.10.1

**What this PR does / why we need it**:
We have supported go1.10.x for a few weeks now (#60597). CI has all been updated. This enforces it as the new minimum go version required go k8s >=1.11

**Release note**:
No release note, as #60597 already had one.
```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.