New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet: notify systemd that kubelet has started #60654

Merged
merged 1 commit into from Mar 3, 2018

Conversation

@dcbw
Member

dcbw commented Mar 1, 2018

This call has no side-effects if systemd is not used or not installed.

Fixes: #59079

@smarterclayton @sjenning

kubelet now notifies systemd that it has finished starting, if systemd is available and running.
@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Mar 1, 2018

Hrm - I put mine right where the sync loop started.

kubelet: notify systemd that kubelet has started
The notify call has no side-effects if systemd is not used or
not installed.

Fixes: #59079

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Mar 2, 2018

@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Mar 2, 2018

This is fine

/approve
/lgtm

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 3, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@dcbw @smarterclayton

Pull Request Labels
  • sig/node: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 3, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@fejta-bot

This comment has been minimized.

fejta-bot commented Mar 3, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 3, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 3, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit c6d0726 into kubernetes:master Mar 3, 2018

13 of 14 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation dcbw authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

holygits added a commit to holygits/kubernetes that referenced this pull request Mar 5, 2018

Merge pull request kubernetes#60654 from dcbw/kubelet-notify-systemd
Apiserver propogate etcd connection errors
Fixes: kubernetes#50622

@holygits

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

kubelet: notify systemd that kubelet has started

This call has no side-effects if systemd is not used or not installed.

Fixes: kubernetes#59079

@smarterclayton @sjenning

```release-note
kubelet now notifies systemd that it has finished starting, if systemd is available and running.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment