Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write the json content type for API responses #607

Merged
merged 1 commit into from Jul 24, 2014

Conversation

Projects
None yet
2 participants
@smarterclayton
Copy link
Contributor

smarterclayton commented Jul 24, 2014

Closes #604

@@ -62,6 +62,21 @@ func NewNotFoundErr(kind, name string) error {
return errNotFound(fmt.Sprintf("%s %q not found", kind, name))
}

type errAlreadyExists string

This comment has been minimized.

@lavalamp

lavalamp Jul 24, 2014

Member

Two thoughts--

Does this type belong in this PR?

If yes, can you generalize this type with the errNotFound type instead of making them distinct types? (e.g., have an httpResponseCode which is 404 for MakeNotFound and 409 (?) for MakeAlreadyExists...

This comment has been minimized.

@smarterclayton

smarterclayton Jul 24, 2014

Author Contributor

It does not - my bad.

This comment has been minimized.

@smarterclayton

smarterclayton Jul 24, 2014

Author Contributor

I will do the generalization with another issue - that's coming from some other prototyping I was doing and mixed my commits.

lavalamp added a commit that referenced this pull request Jul 24, 2014

Merge pull request #607 from smarterclayton/return_correct_content_type
Write the json content type for API responses

@lavalamp lavalamp merged commit 9e9d9b8 into kubernetes:master Jul 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@lavalamp

This comment has been minimized.

Copy link
Member

lavalamp commented Jul 24, 2014

Thanks!

@smarterclayton smarterclayton deleted the smarterclayton:return_correct_content_type branch Feb 11, 2015

mqliang pushed a commit to mqliang/kubernetes that referenced this pull request Dec 8, 2016

metadave pushed a commit to metadave/kubernetes that referenced this pull request Feb 22, 2017

Added ingress support stable/wordpress (kubernetes#607)
* Added ingress support

* Added annotations support

* Change the if order

* Changing the message

* Added TLS config

mqliang pushed a commit to mqliang/kubernetes that referenced this pull request Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.