New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--show-all is inert in v1.11 #60793

Merged
merged 1 commit into from Mar 22, 2018

Conversation

@charrywanganthony
Contributor

charrywanganthony commented Mar 5, 2018

What this PR does / why we need it:

--show-all is inert in v1.11
ref: #60210

Special notes for your reviewer:
/assign @deads2k

Release note:

`--show-all` (which only affected pods and only for human readable/non-API printers) is inert in v1.11, and will be removed in a future release.
@thockin

This comment has been minimized.

Member

thockin commented Mar 5, 2018

This change is Reviewable

@deads2k deads2k added this to the v1.11 milestone Mar 5, 2018

@deads2k

This comment has been minimized.

Contributor

deads2k commented Mar 5, 2018

/assign @soltysh
/assign @juanvallejo

@jdumars

This comment has been minimized.

Member

jdumars commented Mar 5, 2018

/ok-to-test

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Mar 5, 2018

@soltysh this lgtm
@charrywanganthony thanks, looks like you'll also need to update printers_test.go:1574

@charrywanganthony

This comment has been minimized.

Contributor

charrywanganthony commented Mar 6, 2018

@juanvallejo Modified. 😄

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Mar 6, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 6, 2018

}
// show-all is deprecated in v1.10 and inert in v1.11.
// TODO: It will be removed in a future release.
func filterPods(runtime.Object, printers.PrintOptions) bool {

This comment has been minimized.

@deads2k

deads2k Mar 6, 2018

Contributor

why is this still here?

This comment has been minimized.

@charrywanganthony

charrywanganthony Mar 7, 2018

Contributor

I thought it should be removed in the future, let it stay no-op currently. @deads2k

This comment has been minimized.

@deads2k

deads2k Mar 7, 2018

Contributor

The inert bit is about the flag which needs to continue to exist so someone specifying it doesn't get a failure. We don't need to keep cruft in the codebase though.

This comment has been minimized.

@charrywanganthony
@@ -390,32 +390,17 @@ func TestGetObjectsFiltered(t *testing.T) {
flags map[string]string
expect string
}{
{args: []string{"pods", "foo"}, resp: first, flags: map[string]string{"show-all": "true"},

This comment has been minimized.

@deads2k

deads2k Mar 13, 2018

Contributor

sorry I didn't notice before. This entire test function is now dead.

@@ -32,26 +30,7 @@ type FilterFunc func(runtime.Object, printers.PrintOptions) bool
type Filters []FilterFunc

This comment has been minimized.

@deads2k

deads2k Mar 13, 2018

Contributor

There are no filters anymore, so this type should be removed.

This comment has been minimized.

@charrywanganthony

charrywanganthony Mar 13, 2018

Contributor

And how about the entire resource_filter.go file ? And the entire filter structure? @deads2k

This comment has been minimized.

@juanvallejo

juanvallejo Mar 13, 2018

Member

Since we only care about keeping the flag, I would be in favor of removing this file (and any references to it in factory_client_acces.go, get.go)

@deads2k

This comment has been minimized.

Contributor

deads2k commented Mar 13, 2018

/approve

@juanvallejo you have lgtm

@jdumars

This comment has been minimized.

Member

jdumars commented Mar 13, 2018

Code freeze will lift on 3/19, and this will merge after that.

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 16, 2018

@fejta-bot

This comment has been minimized.

fejta-bot commented Mar 20, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

3 similar comments
@fejta-bot

This comment has been minimized.

fejta-bot commented Mar 20, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

fejta-bot commented Mar 20, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@fejta-bot

This comment has been minimized.

fejta-bot commented Mar 21, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 21, 2018

@charrywanganthony

This comment has been minimized.

Contributor

charrywanganthony commented Mar 21, 2018

@juanvallejo still needs LGTM label. 😄

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 21, 2018

@charrywanganthony: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Mar 21, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 21, 2018

@soltysh

/lgtm

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charrywanganthony, deads2k, juanvallejo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh

This comment has been minimized.

Contributor

soltysh commented Mar 21, 2018

/retest

@fejta-bot

This comment has been minimized.

fejta-bot commented Mar 21, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

fejta-bot commented Mar 22, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@charrywanganthony

This comment has been minimized.

Contributor

charrywanganthony commented Mar 22, 2018

/test pull-kubernetes-integration

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 22, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 22, 2018

Automatic merge from submit-queue (batch tested with PRs 60793, 61181, 61267, 61252, 61334). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 114d481 into kubernetes:master Mar 22, 2018

11 of 14 checks passed

pull-kubernetes-integration Job failed.
Details
Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
pull-kubernetes-e2e-gce Job triggered.
Details
cla/linuxfoundation charrywanganthony authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 22, 2018

@charrywanganthony: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration 71a1970 link /test pull-kubernetes-integration
pull-kubernetes-e2e-gce 71a1970 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

CaoShuFeng added a commit to CaoShuFeng/kubernetes that referenced this pull request Mar 26, 2018

k8s-merge-robot added a commit that referenced this pull request Mar 27, 2018

Merge pull request #61688 from CaoShuFeng/remove-a
Automatic merge from submit-queue (batch tested with PRs 60499, 61715, 61688, 61300, 58787). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

remove deprecated -a from cmd test

ref: #60210
ref: #60793



**What this PR does / why we need it**:

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

TaEduard added a commit to TaEduard/kubernetes that referenced this pull request Apr 16, 2018

TaEduard added a commit to TaEduard/kubernetes that referenced this pull request Apr 16, 2018

KIVagant added a commit to KIVagant/kubernetes that referenced this pull request Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment