Made image registries configurable from registry.yaml file #60848

adelina-t · 2018-03-06T16:04:29Z

Make image registries used by e2e tests configurable via a registry.yaml file. File path is sent via env variable. If no such variable is set, registry names default to the ones already defined.

Fixes #60487

k8s-ci-robot · 2018-03-06T16:04:31Z

@adelina-t: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2018-03-06T16:04:31Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ixdy · 2018-03-06T20:08:37Z

can you sign the CLA, please?

ixdy · 2018-03-06T20:09:03Z

/assign
/cc @mkumatag

mkumatag · 2018-03-07T03:52:39Z

@adelina-t what is the proposal here for supporting windows platform? Keeping windows docker images is some other location may not scale for a long run, IMO we should have windows images also co-located with all other images(linux).

adelina-t · 2018-03-13T09:05:02Z

@mkumatag The ideea is to support testing on k8s clusters containing windows on Azure ( for the moment ). Since the cluster will be deployed in Azure we might benefit from locating images in a registry in Azure as well, since the windows images are fairly big.

PatrickLang · 2018-03-19T22:46:34Z

/sig testing

ixdy · 2018-03-06T20:05:45Z

test/registry.yaml

@@ -0,0 +1,4 @@
+e2eRegistry: atuvenie


did you intend for this file to be checked into the repo? if so, renaming this to image_registry.yaml, or placing it in the test/images directory might be a bit clearer.

additionally, this file isn't included in kubernetes-test.tar.gz, so it's not available to e2e tests currently. if you want to include it, you'll need to update build/BUILD:test-portable-targets" and hack/lib/golang.sh:KUBE_TEST_PORTABLE`.

ixdy · 2018-03-06T20:06:02Z

test/utils/image/manifest.go

 )

+type Registry struct {


minor nit: RegistryList, maybe?

ixdy · 2018-03-06T20:07:54Z

test/utils/image/manifest.go

+		SampleRegistry:  "gcr.io/google-samples",
+	}
+
+	if os.Getenv("KUBE_TEST_REPO_LIST") == "" {


can we use a flag instead of an environment variable for this?

ixdy · 2018-03-20T21:49:25Z

/ok-to-test

mkumatag · 2018-09-12T01:30:58Z

At the moment, the flags are being consumed during the module init phase, meaning that we could only initialize TestContext.KubeTestRepoList only during init or after, which is already too late, since plenty of tests require those registries and images to be initialized by the time their modules load.

@ixdy @dims any comments?

test/utils/image/manifest.go

ixdy · 2018-09-17T23:05:34Z

otherwise this basically LGTM

dims · 2018-09-18T12:10:59Z

/release-note-none

dims · 2018-09-18T12:11:38Z

/lgtm

( agree with @ixdy )

adelina-t · 2018-09-18T13:40:21Z

Small change because pull-kubernetes-verify was failing. ( was calling panic with only one param in manifest.go )

ixdy · 2018-09-18T18:56:06Z

/lgtm

k8s-ci-robot · 2018-09-18T18:56:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adelina-t, dims, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/utils/image/OWNERS~~ [ixdy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fejta-bot · 2018-09-24T20:31:45Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

benmoss · 2018-09-24T22:00:51Z

/retest

ixdy · 2018-09-24T23:39:57Z

/retest

ixdy · 2018-09-25T00:43:11Z

/retest

k8s-ci-robot · 2018-09-25T03:17:46Z

@adelina-t: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-kubemark-e2e-gce	5918f2131708a15d93f62fe4f0ff484ade242560	link	`/test pull-kubernetes-kubemark-e2e-gce`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fejta-bot · 2018-09-25T05:37:47Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

k8s-ci-robot requested review from enisoc and ixdy March 6, 2018 16:04

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2018

k8s-ci-robot assigned ixdy Mar 6, 2018

k8s-ci-robot requested a review from mkumatag March 6, 2018 20:09

adelina-t force-pushed the configure_test_image_repo branch from ba0c31e to 882a5b5 Compare March 13, 2018 10:42

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 13, 2018

k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 19, 2018

ixdy reviewed Mar 20, 2018

View reviewed changes

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 20, 2018

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2018

adelina-t force-pushed the configure_test_image_repo branch from 882a5b5 to 9703d55 Compare June 19, 2018 13:42

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2018

adelina-t force-pushed the configure_test_image_repo branch 2 times, most recently from ccd1842 to 5918f21 Compare June 19, 2018 14:36

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2018

claudiubelu force-pushed the configure_test_image_repo branch from 5918f21 to b3bb748 Compare August 28, 2018 10:12

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2018

ixdy reviewed Sep 17, 2018

View reviewed changes

test/utils/image/manifest.go Outdated Show resolved Hide resolved

claudiubelu force-pushed the configure_test_image_repo branch from c8333a0 to 5c99884 Compare September 18, 2018 12:03

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 18, 2018

k8s-ci-robot assigned dims Sep 18, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2018

adelina-t force-pushed the configure_test_image_repo branch from 5c99884 to dc20606 Compare September 18, 2018 13:31

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2018

Made image registries configurable from registry.yaml file

bb59d44

adelina-t force-pushed the configure_test_image_repo branch from dc20606 to bb59d44 Compare September 18, 2018 13:39

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2018

k8s-ci-robot merged commit 06d72ad into kubernetes:master Sep 25, 2018

PatrickLang mentioned this pull request Oct 16, 2018

Conformance tests should be able to pass for mixed OS clusters #69892

Closed

2 tasks

adelina-t mentioned this pull request Dec 17, 2018

REQUEST: New membership for adelina-t kubernetes/org#310

Closed

6 tasks

joshrosso mentioned this pull request Jan 9, 2019

Config option to reference private registry vmware-tanzu/sonobuoy#160

Closed

mkumatag mentioned this pull request May 7, 2019

Add patch method for container images #74703

Merged

Made image registries configurable from registry.yaml file #60848

Made image registries configurable from registry.yaml file #60848

adelina-t commented Mar 6, 2018

k8s-ci-robot commented Mar 6, 2018

k8s-ci-robot commented Mar 6, 2018

ixdy commented Mar 6, 2018

ixdy commented Mar 6, 2018

mkumatag commented Mar 7, 2018

adelina-t commented Mar 13, 2018

PatrickLang commented Mar 19, 2018

ixdy Mar 6, 2018

ixdy Mar 6, 2018

ixdy Mar 6, 2018

ixdy commented Mar 20, 2018

mkumatag commented Sep 12, 2018

ixdy commented Sep 17, 2018

dims commented Sep 18, 2018

dims commented Sep 18, 2018

adelina-t commented Sep 18, 2018

ixdy commented Sep 18, 2018

k8s-ci-robot commented Sep 18, 2018

fejta-bot commented Sep 24, 2018

benmoss commented Sep 24, 2018

ixdy commented Sep 24, 2018

ixdy commented Sep 25, 2018

k8s-ci-robot commented Sep 25, 2018 •

edited

fejta-bot commented Sep 25, 2018

Made image registries configurable from registry.yaml file #60848

Made image registries configurable from registry.yaml file #60848

Conversation

adelina-t commented Mar 6, 2018

k8s-ci-robot commented Mar 6, 2018

k8s-ci-robot commented Mar 6, 2018

ixdy commented Mar 6, 2018

ixdy commented Mar 6, 2018

mkumatag commented Mar 7, 2018

adelina-t commented Mar 13, 2018

PatrickLang commented Mar 19, 2018

ixdy Mar 6, 2018

Choose a reason for hiding this comment

ixdy Mar 6, 2018

Choose a reason for hiding this comment

ixdy Mar 6, 2018

Choose a reason for hiding this comment

ixdy commented Mar 20, 2018

mkumatag commented Sep 12, 2018

ixdy commented Sep 17, 2018

dims commented Sep 18, 2018

dims commented Sep 18, 2018

adelina-t commented Sep 18, 2018

ixdy commented Sep 18, 2018

k8s-ci-robot commented Sep 18, 2018

fejta-bot commented Sep 24, 2018

benmoss commented Sep 24, 2018

ixdy commented Sep 24, 2018

ixdy commented Sep 25, 2018

k8s-ci-robot commented Sep 25, 2018 • edited

fejta-bot commented Sep 25, 2018

k8s-ci-robot commented Sep 25, 2018 •

edited