Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update cadvisor to v0.29.1 #60867
Mar 7, 2018
Mar 7, 2018
status/approved-for-milestone until the release team reviews. We have to be careful during code freeze.
@Random-Liu: Can you please review the comments below, as well as explain what is the risk to containerd installs if this doesn't make the release? This doesn't appear to be a very risky change, but we need to understand the pros/cons
Why we need this change?
If this doesn't make the release, users will sometimes see partial container monitoring stats for Kubernetes+containerd integration, because of the race condition described in google/cadvisor#1894 (comment).
What is the risk?
Thanks for asking for the risk context!
Thanks for the information, @Random-Liu!
From a bumping godep perspective, this lgtm. From the side of inclusion in the 1.10 release, based on the information provided, I think this is a low-risk bug fix. I can't speak authoritatively for this area, however. If sig-node agrees, then I'd support inclusion in 1.10.
[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process
Pull Request Labels
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here