New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --service-account-private-key-file in v1.11 #60875

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
7 participants
@charrywanganthony
Contributor

charrywanganthony commented Mar 7, 2018

kube-cloud-controller-manager flag --service-account-private-key-file is removed in v1.11

ref: #50289

Release note:

`kube-cloud-controller-manager` flag `--service-account-private-key-file` is removed in v1.11
@charrywanganthony

This comment has been minimized.

Contributor

charrywanganthony commented Mar 8, 2018

/assign @liggitt

@CaoShuFeng

This comment has been minimized.

Member

CaoShuFeng commented Mar 8, 2018

/ok-to-test

@wlan0

This comment has been minimized.

Member

wlan0 commented Mar 8, 2018

This looks good. Will defer to @liggitt to approve

@wlan0

wlan0 approved these changes Mar 8, 2018

@liggitt

This comment has been minimized.

Member

liggitt commented Mar 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 8, 2018

@wlan0

This comment has been minimized.

Member

wlan0 commented Mar 8, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charrywanganthony, liggitt, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

fejta-bot commented Mar 16, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

fejta-bot commented Mar 20, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 20, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 20, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit d9008e0 into kubernetes:master Mar 20, 2018

13 of 14 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation charrywanganthony authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment