Mark reconstructed volumes as reported InUse

[jsafrane]

When a newly started kubelet finds a directory where a volume should be,
it can be fairly confident that the volume was mounted by previous kubelet
and therefore the volume must have been in node.status.volumesInUse.

Therefore we can mark reconstructed volumes as already reported so
subsequent reconcile() can fix the directory and put the mounted volume
into actual state of world.

Fixes: #60645

Release note:

NONE

/sig storage
/sig node
cc: @gnufied @jingxu97

[gnufied]

/lgtm

[dims]

/milestone v1.10

[gnufied]

/test pull-kubernetes-e2e-gce

[jsafrane]

@jingxu97 @saad-ali, PTAL and approve it for 1.10 if we want this to be the fix for orphaned pod directories, thanks.

[jingxu97]

Should we move this part right after line 367? If desired state has the volume and the volume directory already exist, we can mark the ReportInUse in the desired state.

Ideally, we can check node status to make sure the reportinuse field has the volume

[jsafrane]

I originally put it here because I did not want volumes that failed reconstruction to be reported. I'll move the check up as you suggest.

[jsafrane]

@jingxu97 @gnufied, fixed the PR, PTAL

[jsafrane]

Oh, NOW I remember why the code is as it is! Without successful reconstruction I don't have reconstructedVolume.volumeName to put into volumeNeedReport (and call MarkVolumesReportedInUse).

I reverted the PR back to the original state.

[gnufied]

/test pull-kubernetes-e2e-kops-aws

[gnufied]

/lgtm

[jingxu97]

/approve

[gnufied]

@saad-ali can you approve this PR?

[saad-ali]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, jingxu97, jsafrane, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/volumemanager/OWNERS [saad-ali]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@gnufied @jsafrane

Pull Request Labels

• sig/node sig/storage: Pull Request will be escalated to these SIGs if needed.
• priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
• kind/bug: Fixes a bug discovered during the current release.

Help

• Additional instructions
• Commands for setting labels

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 60888, 61225). If you want to cherry-pick this change to another branch, please follow the instructions here.