New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't do attach and deatch when cinder volume status is error #61082

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Projects
None yet
6 participants
@wenlxie
Contributor

wenlxie commented Mar 13, 2018

When cinder volume status is error, it is not supposed to handle operation like attach and detach

@dims @FengyunPan2

cinder volume plugin : 
When the cinder volume status is `error`,  controller will not do `attach ` and `detach ` operation
@FengyunPan2

This comment has been minimized.

Contributor

FengyunPan2 commented Mar 13, 2018

/ok-to-test

@dims

This comment has been minimized.

Member

dims commented Apr 5, 2018

/approve

@FengyunPan2

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 10, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, FengyunPan2, wenlxie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wenlxie

This comment has been minimized.

Contributor

wenlxie commented Apr 10, 2018

@FengyunPan2 @dims Can you help to trigger the failure test?
It should be not related to this PR

@FengyunPan2

This comment has been minimized.

Contributor

FengyunPan2 commented Apr 10, 2018

/retest

@FengyunPan2

This comment has been minimized.

Contributor

FengyunPan2 commented Apr 10, 2018

/test pull-kubernetes-e2e-gce

@fejta-bot

This comment has been minimized.

fejta-bot commented Apr 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

fejta-bot commented Apr 10, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 11, 2018

Automatic merge from submit-queue (batch tested with PRs 61549, 62230, 62055, 61082, 62212). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 27045d3 into kubernetes:master Apr 11, 2018

15 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation wenlxie authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment