New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kubectl_filedir completion #61129

Merged
merged 1 commit into from Mar 14, 2018

Conversation

@juanvallejo
Member

juanvallejo commented Mar 13, 2018

Fixes #61017

Release note:

NONE

Issue was reproduced and verified fixed using steps from #61017 (comment)

kubectl was checked outside of the above environment, to ensure it worked in local environment as well

cc @seans3 @soltysh

@cblecker

This comment has been minimized.

Member

cblecker commented Mar 13, 2018

/ok-to-test

@soltysh

/lgtm

@liggitt

This comment has been minimized.

Member

liggitt commented Mar 13, 2018

/sig cli
/lgtm

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 13, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@juanvallejo @liggitt @soltysh

Pull Request Labels
  • sig/cli: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@timothysc

/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 13, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanvallejo, liggitt, soltysh, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 14, 2018

Automatic merge from submit-queue (batch tested with PRs 61129, 60359). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 1ba03c0 into kubernetes:master Mar 14, 2018

14 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation juanvallejo authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@dixudx

This comment has been minimized.

Member

dixudx commented Mar 14, 2018

@juanvallejo Please cherry pick to release-1.10.

@cblecker

This comment has been minimized.

Member

cblecker commented Mar 14, 2018

@dixudx we are still in fast forwards, so no cherrypick is needed

@juanvallejo juanvallejo deleted the juanvallejo:jvallejo/fix-zsh-completion-debug branch Mar 14, 2018

@sttts

This comment has been minimized.

Contributor

sttts commented on cmd/kubeadm/app/cmd/completion.go in 3dc952e Aug 22, 2018

where does __kubectl_debug come from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment