New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error check after getting clientset to make sure clientset is not nil #61130
Conversation
/sig cli |
/assign @mengqiy |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Liujingfang1, mengqiy Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can you update the PR description to include
|
/test all Tests are more than 96 hours old. Re-running tests. |
@Liujingfang1 Please rebase :) |
@Liujingfang1: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The change has been covered by #60455 |
What this PR does / why we need it:
Current code doesn't have error check after getting clientset. If clientset is nil, the subsequent code will have runtime error. kubernetes/kubectl#226
Fixes kubernetes/kubectl#226
Special notes for your reviewer:
Release note: