New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated gcloud compute networks --mode switches. #61203

Merged
merged 1 commit into from Mar 16, 2018

Conversation

@rmmh
Contributor

rmmh commented Mar 14, 2018

"create --mode" becomes "create --subnet-mode", and switch-mode has been
folded into "update".

Create --mode was deprecated in October and will be removed in the next
gcloud release. It is already failing in staging tests.
What this PR does / why we need it:

Which issue(s) this PR fixes Fixes #54238

Special notes for your reviewer:

Release note:

NONE
@@ -1675,7 +1675,7 @@ function create-network() {
function expand-default-subnetwork() {
gcloud compute networks switch-mode "${NETWORK}" \
--mode custom \

This comment has been minimized.

@ixdy

ixdy Mar 14, 2018

Member

this one is still --subnet-mode.

This comment has been minimized.

@ixdy

ixdy Mar 14, 2018

Member

but also

SYNOPSIS
    gcloud compute networks switch-mode NAME --mode=MODE [GCLOUD_WIDE_FLAG ...]

DESCRIPTION
    (DEPRECATED) switch-mode is deprecated. Please use
    --switch-to-custom-subnet-mode with gcloud compute networks update instead.

    gcloud compute networks switch-mode is used to change the mode of a
    network. Currently, only changing from auto to custom mode is supported.

This comment has been minimized.

@rmmh

rmmh Mar 14, 2018

Contributor

Done!

Fix deprecated gcloud compute networks --mode switches.
"create --mode" becomes "create --subnet-mode", and switch-mode has been
folded into "update".

Create --mode was deprecated in October and will be removed in the next
gcloud release. It is already failing in staging tests.

@rmmh rmmh changed the title from Use gcloud compute networks --subnet-mode instead of --mode. to Fix deprecated gcloud compute networks --mode switches. Mar 14, 2018

@rmmh

This comment has been minimized.

Contributor

rmmh commented Mar 14, 2018

/retest

@krzyzacy

This comment has been minimized.

Member

krzyzacy commented Mar 14, 2018

gke test need a kubetest bump, sending out

@cblecker

This comment has been minimized.

Member

cblecker commented Mar 14, 2018

/sig testing
/priority critical-urgent
/kind bug

@krzyzacy

This comment has been minimized.

Member

krzyzacy commented Mar 14, 2018

/status approved-for-milestone

@cblecker

This comment has been minimized.

Member

cblecker commented Mar 14, 2018

/lgtm

@rmmh

This comment has been minimized.

Contributor

rmmh commented Mar 14, 2018

/retest

@krzyzacy

This comment has been minimized.

Member

krzyzacy commented Mar 14, 2018

/retest
gce looks like flaky

@ixdy

This comment has been minimized.

Member

ixdy commented Mar 14, 2018

hmm:

failed to create Stackdriver Logging sink: googleapi: Error 400: There is a maximum of 90 sinks allowed, failedPrecondition
@cblecker

This comment has been minimized.

Member

cblecker commented Mar 15, 2018

/assign @gmarek
for approval

@liggitt

This comment has been minimized.

Member

liggitt commented Mar 15, 2018

are these changes needed in release branches as well?

@krzyzacy

This comment has been minimized.

Member

krzyzacy commented Mar 15, 2018

@liggitt yep (this will not be blocking for gce until this gcloud staging version come to prod, and we bump gcloud in e2e image)

@krzyzacy

This comment has been minimized.

Member

krzyzacy commented Mar 15, 2018

/assign @mikedanese @roberthbailey
can someone approve?

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 15, 2018

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@cblecker @gmarek @krzyzacy @mikedanese @rmmh @roberthbailey

Pull Request Labels
  • sig/testing: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help
@roberthbailey

This comment has been minimized.

Member

roberthbailey commented Mar 15, 2018

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Mar 15, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, rmmh, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey

This comment has been minimized.

Member

roberthbailey commented Mar 15, 2018

Do we need to backport this to any old release branches to keep the upgrade tests working?

@tpepper

This comment has been minimized.

Contributor

tpepper commented Mar 15, 2018

@roberthbailey see #54238 for the over arching issue status. Indication there is yes on backports.

@krzyzacy

This comment has been minimized.

Member

krzyzacy commented Mar 15, 2018

yep, we don't bind kubernetes with specific gcloud versions, each active branch should be able to run with latest gcloud.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Mar 16, 2018

Automatic merge from submit-queue (batch tested with PRs 61203, 61071). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 5f78093 into kubernetes:master Mar 16, 2018

14 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation rmmh authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Job succeeded.
Details
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

k8s-merge-robot added a commit that referenced this pull request Apr 11, 2018

Merge pull request #62381 from shyamjvs/automated-cherry-pick-of-#61203
…-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #61203: Fix deprecated gcloud compute networks --mode switches.

Cherry pick of #61203 on release-1.9.

#61203: Fix deprecated gcloud compute networks --mode switches.

```release-note
NONE
```

k8s-merge-robot added a commit that referenced this pull request Apr 11, 2018

Merge pull request #62380 from wojtek-t/automated-cherry-pick-of-#61203
…-upstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #61203 upstream release 1.8

Cherry pick of #61203 on release-1.8.
#61203 : Fix deprecated gcloud compute networks --mode switches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment